fix: do not generate xerror when no enum found (#704)

Makefile

@@ -51,6 +51,7 @@ init:
 	go install github.com/go-swagger/go-swagger/cmd/swagger@v0.30.4
 	cd ./cmd/protoc-gen-go-echo && go install .
 	cd ./cmd/protoc-gen-go-gin && go install .
+	cd ./cmd/protoc-gen-go-xerror && go install .
 
 # update buf mod
 update:

buf.gen.yaml

@@ -6,6 +6,11 @@ plugins:
     opt:
       - paths=source_relative
 
+  - name: go-xerror
+    out: proto
+    opt:
+      - paths=source_relative
+
   - name: go-grpc
     out: proto
     opt:

cmd/protoc-gen-go-xerror/xerror.go

@@ -18,9 +18,11 @@ const (
 
 // generateFile generates a _error.pb.go file.
 func generateFile(gen *protogen.Plugin, file *protogen.File) *protogen.GeneratedFile {
-	if len(file.Services) == 0 {
+	errorInfos := genErrors(gen, file)
+	if len(errorInfos.Errors) == 0 {
 		return nil
 	}
+
 	filename := file.GeneratedFilenamePrefix + "_xerror.pb.go"
 	g := gen.NewGeneratedFile(filename, file.GoImportPath)
 	g.P("// Code generated by github.com/douyu/jupiter/cmd/protoc-gen-go-xerror. DO NOT EDIT.")
@@ -35,12 +37,12 @@ func generateFile(gen *protogen.Plugin, file *protogen.File) *protogen.Generated
 	g.P("var _ = new(", xerrorPkg.Ident("Err"), ")")
 	g.P()
 
-	genErrors(gen, file, g)
+	g.P(errorInfos.execute())
 
 	return g
 }
 
-func genErrors(gen *protogen.Plugin, file *protogen.File, g *protogen.GeneratedFile) {
+func genErrors(gen *protogen.Plugin, file *protogen.File) *errorInfos {
 	errorInfos := new(errorInfos)
 	for _, enum := range file.Enums {
 		for _, enumValue := range enum.Values {
@@ -56,7 +58,7 @@ func genErrors(gen *protogen.Plugin, file *protogen.File, g *protogen.GeneratedF
 		}
 	}
 
-	g.P(errorInfos.execute())
+	return errorInfos
 }
 
 func protocVersion(gen *protogen.Plugin) string {

proto/error/v1/error.proto

@@ -4,7 +4,7 @@ package error.v1;
 
 import "google/protobuf/descriptor.proto";
 
-option go_package = "github.com/douyu/jupiter-layout/api/error/v1;errorv1";
+option go_package = "github.com/douyu/jupiter/proto/error/v1;errorv1";
 option java_multiple_files = true;
 option java_outer_classname = "ErrorProtoV1";
 option java_package = "com.douyu.error.v1";

proto/helloworld/v1/error.proto

@@ -0,0 +1,18 @@
+syntax = "proto3";
+
+package helloworld.v1;
+
+import "error/v1/error.proto";
+
+option go_package = "github.com/douyu/jupiter/proto/helloworld/v1;helloworldv1";
+option java_multiple_files = true;
+option java_outer_classname = "HelloWorldProtoV1";
+option java_package = "com.douyu.helloworld.v1";
+
+// Error codes for the helloworld.v1 package.
+enum Error {
+  // ERROR_UNSPECIFIED is the invalid code.
+  ERROR_UNSPECIFIED = 0;
+  // ERROR_NAME_INVALID is the error code for invalid name.
+  ERROR_NAME_INVALID = 1000 [(error.v1.msg) = "name is invalid"];
+}

proto/helloworld/v1/error.swagger.json

@@ -0,0 +1,15 @@
+{
+  "swagger": "2.0",
+  "info": {
+    "title": "helloworld/v1/error.proto",
+    "version": "version not set"
+  },
+  "consumes": [
+    "application/json"
+  ],
+  "produces": [
+    "application/json"
+  ],
+  "paths": {},
+  "definitions": {}
+}