Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] "PreferUpperCamelIfMissed" has some strange problem #15

Closed
neville1 opened this issue Aug 22, 2019 · 1 comment
Closed

[Bug] "PreferUpperCamelIfMissed" has some strange problem #15

neville1 opened this issue Aug 22, 2019 · 1 comment

Comments

@neville1
Copy link
Contributor

When I set "PreferUpperCamelIfMissed = true", I will get error like this

<11, 28> Variable : u32StreamId (uint32_t)
<105, 50> Parameter: u8RxSeq (uint8_t)
@dougpuob dougpuob mentioned this issue Apr 1, 2020
Merged
dougpuob added a commit that referenced this issue Apr 1, 2020
@dougpuob
Fixed issue #15 "PreferUpperCamelIfMissed" has some strange problem.
2781f7a 
Fixed issue #15 "PreferUpperCamelIfMissed" has some strange problem.

Why:
Missed case in Detection.cpp!_IsHungarianNotationString() function.

HowToFix:
Fixed it and added new unit test case, PreferUpperCamelIfMissed, in TestDetection.cpp file.
@dougpuob
Copy link
Owner

dougpuob commented Apr 1, 2020

This issue was fixed in this PR(#37.)

@dougpuob dougpuob closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neville1 @dougpuob