Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove v1 (Jackbox-style) UI flows, then all v1 code #572

Open
douglasnaphas opened this issue Mar 10, 2024 · 3 comments
Open

Remove v1 (Jackbox-style) UI flows, then all v1 code #572

douglasnaphas opened this issue Mar 10, 2024 · 3 comments
Labels
passover Mad Liberation

Comments

@douglasnaphas
Copy link
Owner

v2 (links) works. I want people to use that.
@douglasnaphas douglasnaphas added the passover Mad Liberation label Mar 10, 2024
@douglasnaphas douglasnaphas moved this to In Progress in Mad Liberation v6 2024 Mar 21, 2024
@douglasnaphas
Copy link
Owner Author

Duplicate of gh-571, closing.

@douglasnaphas douglasnaphas closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mad Liberation v6 2024 Mar 21, 2024
@douglasnaphas douglasnaphas moved this from Done to Won't Do in Mad Liberation v6 2024 Mar 21, 2024
@douglasnaphas
Copy link
Owner Author

Re-opening. Not exactly a duplicate. gh-571 is "make links the primary flow," this is "remove the v1 flow."

@douglasnaphas douglasnaphas reopened this Mar 21, 2024
@douglasnaphas douglasnaphas moved this from Won't Do to Prioritized Backlog in Mad Liberation v6 2024 Mar 21, 2024
@douglasnaphas
Copy link
Owner Author

At least remove a lot of the unused code. It's getting pretty confusing having, for example, code in backend-v2 that is only there from copying it over from backend v1.

I would like to remove the v1 flows and buttons. I don't want people using the Jackbox flow, because it is brittle.

@douglasnaphas douglasnaphas moved this from Prioritized Backlog to In Progress in Mad Liberation v6 2024 Mar 26, 2024
douglasnaphas added a commit that referenced this issue Mar 26, 2024
@douglasnaphas
Remove v1 links from the Home Page
91c5d64 
gh-572

The v1 flow is too brittle. It will be confusing having login be
meaningful for v1 and v2 simultaneously.

Any shortcomings of v2 do not outweigh the risk that v1 carries of
lockout.
douglasnaphas added a commit that referenced this issue Apr 6, 2024
@douglasnaphas
Pull opaque cookie info from schema v2
3e83140 
gh-572

I'd like to remove backend v1 entirely.
douglasnaphas added a commit that referenced this issue Apr 10, 2024
@douglasnaphas
Remove itest-staging from CI workflow
07d58bb 
gh-572
douglasnaphas added a commit that referenced this issue Apr 10, 2024
@douglasnaphas
Don't itest the prod site v1 flow
7f7017a 
gh-572
douglasnaphas added a commit that referenced this issue Apr 10, 2024
@douglasnaphas
Give backend v2 the Cognito env vars
6472203 
gh-572

I want to remove all of backend v1.
douglasnaphas added a commit that referenced this issue Apr 10, 2024
@douglasnaphas
Use v2 for login
c79935e 
gh-572

A step towards removing v1 backend.
@douglasnaphas douglasnaphas moved this from In Progress to Prioritized Backlog in Mad Liberation v6 2024 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
passover Mad Liberation
Projects
Mad Liberation v6 2024
Status: Prioritized Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@douglasnaphas