Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizing output paths #5

Closed
pkra opened this issue Jun 7, 2018 · 3 comments
Closed

customizing output paths #5

pkra opened this issue Jun 7, 2018 · 3 comments
Assignees
Milestone

Comments

@pkra
Copy link

pkra commented Jun 7, 2018

First off, thanks for making this -- I find it very appealing.

Right now there's

fse.writeFileSync(`${destPath}/${fileData.name}.html`, completePage);

I tend to prefer something like

fse.writeFileSync(`${destPath}/${fileData.name}/index.html`, completePage);

I'm happy to just fork to keep things as concise as they are right now. But I thought I'd ask what you think.

@doug2k1
Copy link
Owner

doug2k1 commented Jun 7, 2018

Hi! Good suggestion! It would simplify the site links.

I'll add to the features for the next release.

Thanks!

@doug2k1 doug2k1 self-assigned this Jun 7, 2018
@doug2k1 doug2k1 added this to the 0.3 milestone Jun 7, 2018
@doug2k1
Copy link
Owner

doug2k1 commented Jun 7, 2018

Done. The only extra verification I had to do is if the original file name is already index, it does not create index/index.html. ;-)

If you encounter any problem, let me know.

@doug2k1 doug2k1 closed this as completed Jun 7, 2018
@pkra
Copy link
Author

pkra commented Jun 9, 2018

Awesome. Thanks for making the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants