Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added context support #64

Merged
merged 5 commits into from
Sep 10, 2018
Merged

added context support #64

merged 5 commits into from
Sep 10, 2018

Conversation

cmoad
Copy link
Contributor

@cmoad cmoad commented Jul 11, 2018

Added support for passing context into all calls that hit the database. I was unable to get the test suite running on my machine to verify. Opened #63 related to that problem.

@cmoad
Copy link
Contributor Author

cmoad commented Jul 11, 2018

Resolves #59

@cmoad
Copy link
Contributor Author

cmoad commented Jul 11, 2018

Pushed a fix for #63. I'll work on adding more coverage for context tests now.

@cmoad cmoad mentioned this pull request Jul 11, 2018
@codecov
Copy link

codecov bot commented Jul 27, 2018

Codecov Report

Merging #64 into master will decrease coverage by 2.26%.
The diff coverage is 29.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   82.98%   80.72%   -2.27%     
==========================================
  Files          17       17              
  Lines        2087     2169      +82     
==========================================
+ Hits         1732     1751      +19     
- Misses        247      310      +63     
  Partials      108      108
Impacted Files Coverage Δ
dataset_actions.go 52.38% <0%> (-32.24%) ⬇️
crud_exec.go 86.95% <100%> (+0.66%) ⬆️
database.go 69.65% <18.75%> (-25.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd495d7...1b2127a. Read the comment docs.

@cmoad
Copy link
Contributor Author

cmoad commented Aug 31, 2018

We've been using this code for a while with success. The checks are failing for go version 1.6 because context wasn't a standard library. It's failing with go 1.7 because the sql package didn't have context support. This branch works in go 1.8 and up. There's nothing I can do to fix those tests. Perhaps this PR should be included in a new major version that only supports go 1.8 and up?

@doug-martin
Copy link
Owner

Yeah, I think that would be the best route. If you want to update travis to test 1.8, 1.9, and latest` that would be great!

@doug-martin doug-martin merged commit 7a3ffce into doug-martin:master Sep 10, 2018
@doug-martin doug-martin mentioned this pull request Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants