-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added context support #64
Conversation
Resolves #59 |
Pushed a fix for #63. I'll work on adding more coverage for context tests now. |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 82.98% 80.72% -2.27%
==========================================
Files 17 17
Lines 2087 2169 +82
==========================================
+ Hits 1732 1751 +19
- Misses 247 310 +63
Partials 108 108
Continue to review full report at Codecov.
|
We've been using this code for a while with success. The checks are failing for go version 1.6 because context wasn't a standard library. It's failing with go 1.7 because the sql package didn't have context support. This branch works in go 1.8 and up. There's nothing I can do to fix those tests. Perhaps this PR should be included in a new major version that only supports go 1.8 and up? |
Yeah, I think that would be the best route. If you want to update travis to test |
Added support for passing context into all calls that hit the database. I was unable to get the test suite running on my machine to verify. Opened #63 related to that problem.