Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert select on conflict do update #55

Merged
merged 2 commits into from
Dec 27, 2017
Merged

Conversation

bobrnor
Copy link
Contributor

@bobrnor bobrnor commented Nov 30, 2017

I fixed an issue when builder does not add on conflict section into insert query with data set instead of slice of records. Test included.

@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #55 into master will decrease coverage by 0.1%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   80.48%   80.38%   -0.11%     
==========================================
  Files          17       17              
  Lines        2337     2340       +3     
==========================================
  Hits         1881     1881              
- Misses        349      351       +2     
- Partials      107      108       +1
Impacted Files Coverage Δ
dataset_insert.go 72.9% <40%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60f7d8...572ad21. Read the comment docs.

@bobrnor
Copy link
Contributor Author

bobrnor commented Dec 25, 2017

Hello! Will this merge request would be merged in?

@doug-martin doug-martin merged commit 846acc3 into doug-martin:master Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants