Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add literal bytes and update to c2fo testify #15

Merged
merged 1 commit into from
Aug 25, 2015
Merged

Add literal bytes and update to c2fo testify #15

merged 1 commit into from
Aug 25, 2015

Conversation

TechnotronicOz
Copy link
Contributor

  • Add support for accepting a slice of bytes for literal serialization
  • Updated Goqu to use C2FO fork of Testify

doug-martin
doug-martin reviewed Aug 24, 2015
View reviewed changes
dataset.go
@@ -194,6 +194,8 @@ func (me *Dataset) Literal(buf *SqlBuilder, val interface{}) error {
return me.adapter.LiteralFloat(buf, v)
} else if v, ok := val.(string); ok {
return me.adapter.LiteralString(buf, v)
} else if v, ok := val.([]byte); ok {
return me.adapter.LiteralBytes(buf, v)
} else if v, ok := val.(bool); ok {
return me.adapter.LiteralBool(buf, v)
} else if v, ok := val.([]byte); ok {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete this as its dead code now

@TechnotronicOz
Copy link
Contributor Author

@doug-martin updated

doug-martin added a commit that referenced this pull request Aug 25, 2015
@doug-martin
Merge pull request #15 from TechnotronicOz/literal_bytes
47a9715 
Add literal bytes and update to c2fo testify
@doug-martin doug-martin merged commit 47a9715 into doug-martin:master Aug 25, 2015
doug-martin added a commit that referenced this pull request Aug 25, 2015
@doug-martin
v3.0.1
95fc6b7 
* Add literal bytes and update to c2fo testify
[#15](#15) -
[@TechnotronicOz](https://github.com/TechnotronicOz)
* Refactored escaping of text types to prevent duplication of logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TechnotronicOz @doug-martin