-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window function support #148
Conversation
doug-martin
commented
Aug 25, 2019
- [ADDED] Window Function support Added Window Function support #128
b3ef211
to
1818910
Compare
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 91.86% 93.82% +1.96%
==========================================
Files 53 55 +2
Lines 3589 3823 +234
==========================================
+ Hits 3297 3587 +290
+ Misses 273 217 -56
Partials 19 19
Continue to review full report at Codecov.
|
1818910
to
54a6da8
Compare
@Xuyuanp thank you for the pull request and including all the tests and examples great job! I had to make a few changes to make the expressions and sql generation work. The most notable ones were:
|
I also want to note that I ended up going with the snake case function names like you suggested, It does read better and keeps with the already established function naming conventions. |
54a6da8
to
aedf6bd
Compare
aedf6bd
to
939c031
Compare
@doug-martin |