Collection: fix insertMany success return type InsertManyResult<I> to…

… allow custom defined _id types
doubleloop-io · Jan 10, 2025 · bd026cf · bd026cf
1 parent 3f9d487
commit bd026cf
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/spotty-hairs-sell.md b/.changeset/spotty-hairs-sell.md
@@ -0,0 +1,5 @@
+---
+"effect-mongodb": patch
+---
+
+Fix `Collection.insertMany` success return type `InsertManyResult<I>` to allow custom defined `_id` types
diff --git a/packages/effect-mongodb/dtslint/Collection.ts b/packages/effect-mongodb/dtslint/Collection.ts
@@ -51,10 +51,10 @@ F.pipe(collection, Collection.insertOne(myType))
 // insertMany
 // -------------------------------------------------------------------------------------
 
-// $ExpectType Effect<InsertManyResult<Document>, MongoError | ParseError, never>
+// $ExpectType Effect<InsertManyResult<{ readonly birthday: string; }>, MongoError | ParseError, never>
 Collection.insertMany(collection, [myType])
 
-// $ExpectType Effect<InsertManyResult<Document>, MongoError | ParseError, never>
+// $ExpectType Effect<InsertManyResult<{ readonly birthday: string; }>, MongoError | ParseError, never>
 F.pipe(collection, Collection.insertMany([myType]))
 
 // -------------------------------------------------------------------------------------

diff --git a/packages/effect-mongodb/src/Collection.ts b/packages/effect-mongodb/src/Collection.ts
@@ -121,17 +121,17 @@ export const insertOne: {
 export const insertMany: {
   <A extends Document>(docs: ReadonlyArray<A>, options?: BulkWriteOptions): <I extends Document, R>(
     collection: Collection<A, I, R>
-  ) => Effect.Effect<InsertManyResult, MongoError.MongoError | ParseResult.ParseError, R>
+  ) => Effect.Effect<InsertManyResult<I>, MongoError.MongoError | ParseResult.ParseError, R>
   <A extends Document, I extends Document, R>(
     collection: Collection<A, I, R>,
     docs: ReadonlyArray<A>,
     options?: BulkWriteOptions
-  ): Effect.Effect<InsertManyResult, MongoError.MongoError | ParseResult.ParseError, R>
+  ): Effect.Effect<InsertManyResult<I>, MongoError.MongoError | ParseResult.ParseError, R>
 } = F.dual((args) => isCollection(args[0]), <A extends Document, I extends Document, R>(
   collection: Collection<A, I, R>,
   docs: ReadonlyArray<A>,
   options?: BulkWriteOptions
-): Effect.Effect<InsertManyResult, MongoError.MongoError | ParseResult.ParseError, R> => {
+): Effect.Effect<InsertManyResult<I>, MongoError.MongoError | ParseResult.ParseError, R> => {
   return F.pipe(
     docs,
     Effect.forEach((doc) => collection.encode(doc)),