Stabilize reflect SymbolMethods.isSuperAccessor

dotty-staging · Apr 22, 2024 · 80a0cb5 · 80a0cb5
1 parent 2ca0ce7
commit 80a0cb5
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 9 deletions.
diff --git a/library/src/scala/quoted/Quotes.scala b/library/src/scala/quoted/Quotes.scala
@@ -4032,7 +4032,6 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching =>
         def isClassConstructor: Boolean
 
         /** Is this the super accessor? */
-        @experimental // TODO when stable, remove `dotty.tools.scaladoc.tasty.ClassLikeSupport.isSuperBridgeMethod` and use this method
         def isSuperAccessor: Boolean
 
         /** Is this the definition of a type? */

diff --git a/project/MiMaFilters.scala b/project/MiMaFilters.scala
@@ -48,7 +48,10 @@ object MiMaFilters {
       // Only exceptional cases should be added here.
 
       // Breaking changes since last reference version
-      Build.mimaPreviousDottyVersion -> Seq.empty, // We should never break backwards compatibility
+      Build.mimaPreviousDottyVersion -> // Seq.empty, // We should never break backwards compatibility
+        Seq(
+          ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.quoted.Quotes#reflectModule#SymbolMethods.isSuperAccessor"), // This change is acceptable. See comment in `Breaking changes since last LTS`.
+        ),
 
       // Breaking changes since last LTS
       Build.mimaPreviousLTSDottyVersion -> Seq(

diff --git a/scaladoc/src/dotty/tools/scaladoc/tasty/ClassLikeSupport.scala b/scaladoc/src/dotty/tools/scaladoc/tasty/ClassLikeSupport.scala
@@ -235,7 +235,7 @@ trait ClassLikeSupport:
   extension (c: ClassDef)
     def extractMembers: Seq[Member] = {
       val inherited = c.getNonTrivialInheritedMemberTrees.collect {
-        case dd: DefDef if !dd.symbol.isClassConstructor && !(dd.symbol.isSuperBridgeMethod || dd.symbol.isDefaultHelperMethod) => dd
+        case dd: DefDef if !dd.symbol.isClassConstructor && !(dd.symbol.isSuperAccessor || dd.symbol.isDefaultHelperMethod) => dd
         case other => other
       }
       c.membersToDocument.flatMap(parseMember(c)) ++

diff --git a/scaladoc/src/dotty/tools/scaladoc/tasty/SyntheticSupport.scala b/scaladoc/src/dotty/tools/scaladoc/tasty/SyntheticSupport.scala
@@ -10,9 +10,6 @@ object SyntheticsSupport:
       import reflect._
       s.flags.is(Flags.Synthetic) || s.flags.is(Flags.FieldAccessor) || s.isDefaultHelperMethod
 
-    // TODO remove and use `SymbolMethods.isSuperAccessor`
-    def isSuperBridgeMethod: Boolean = s.name.contains("$super$")
-
     def isDefaultHelperMethod: Boolean = ".*\\$default\\$\\d+$".r.matches(s.name)
 
     def isOpaque: Boolean =

diff --git a/tests/run-tasty-inspector/stdlibExperimentalDefinitions.scala b/tests/run-tasty-inspector/stdlibExperimentalDefinitions.scala
@@ -51,9 +51,7 @@ val experimentalDefinitionInLibrary = Set(
   "scala.annotation.init$.widen",
   "scala.annotation.init$.region",
 
-   //// New APIs: Quotes
-  // Can be stabilized in 3.5.0 or later
-  "scala.quoted.Quotes.reflectModule.SymbolMethods.isSuperAccessor",
+  //// New APIs: Quotes
   // Can be stabilized in 3.5.0 (unsure) or later
   "scala.quoted.Quotes.reflectModule.CompilationInfoModule.XmacroSettings",
   // Cant be stabilized yet.