[wasm][tests] Identify tests that throw PNSE #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- These tests show up as `[PNSE] System.Net.Http.Functional.Tests.SocketsHttpHandler_Connect_Test.ConnectMethod_Success` And the test results show: `Tests run: 1774, Errors: 0, Failures: 13, PNSE: 1226, Skipped: 71. Time: 10.198805s` Here `PNSE:` shows the count for tests that throw PNSE. And `Failures` *do not* include PNSE failures. In the xml report, such tests are shown with `result="PNSE"`: ```xml <test name="System.Net.Http.Functional.Tests.SyncHttpHandler_Connect_Test.ConnectMethod_Success" type="System.Net.Http.Functional.Tests.SyncHttpHandler_Connect_Test" method="ConnectMethod_Success" time="0.000525" result="PNSE"> ``` .. instead of `result="Fail"`. To detect these, we look for exception-type==PNSE . This still misses cases where the exception might be wrapped in others. We could check the messages xml element to get those too, but that might give us false positives. Eg problem case: `System.Net.Http.Functional.Tests.HttpClientTest.CancelAllPending_AllPendingOperationsCanceled` - this uses `Assert.All`, so you get bunch of exceptions wrapped in `Xunit.Sdk.AllException`.
|
I'll refactor this a bit to move the wasm specific stuff. |
|
I don't understand why we want this? There will be issues with other parts of the system that don't expect a |
lewing
reviewed
Sep 26, 2020
|
For the record I'd love to be able to supply custom filter code to categorize failures at the point of failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[PNSE] System.Net.Http.Functional.Tests.SocketsHttpHandler_Connect_Test.ConnectMethod_SuccessAnd the test results show:
Tests run: 1774, Errors: 0, Failures: 13, PNSE: 1226, Skipped: 71. Time: 10.198805sHere
PNSE:shows the count for tests that throw PNSE.And
Failuresdo not include PNSE failures.In the xml report, such tests are shown with
result="PNSE":.. instead of
result="Fail".To detect these, we look for exception-type==PNSE .
This still misses cases where the exception might be wrapped in others.
We could check the messages xml element to get those too, but that might give us false positives.
Eg problem case:
System.Net.Http.Functional.Tests.HttpClientTest.CancelAllPending_AllPendingOperationsCanceled- this uses
Assert.All, so you get bunch of exceptions wrapped inXunit.Sdk.AllException.