[wasm] Allow serving of unknown files #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, we only serve files with known MIME types, but that is an issue when dotnet library tests consume over a hundred different file extensions in their tests
radical
reviewed
Aug 20, 2020
| @@ -31,7 +31,8 @@ public void Configure(IApplicationBuilder app) | |||
| app.UseStaticFiles(new StaticFileOptions | |||
| { | |||
| FileProvider = new PhysicalFileProvider(s_hostingEnvironment.ContentRootPath), | |||
| ContentTypeProvider = provider | |||
| ContentTypeProvider = provider, | |||
| ServeUnknownFileTypes = true | |||
There was a problem hiding this comment.
Maybe add the commit message here as a comment too, so, somebody in future doesn't end up removing this?
There was a problem hiding this comment.
Isn't that what git blame is for?
There was a problem hiding this comment.
heh true. I guess, I had ended up missing it the last time, but that was because of a comment! Ignore me 👍
radical
approved these changes
Aug 20, 2020
akoeplinger
approved these changes
Aug 20, 2020
mandel-macaque
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we only serve files with known MIME types, but that is an issue when dotnet library tests consume over a hundred different file extensions in their tests