Fix build error sourcelink EmbedUntrackedSources #8378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ghost
requested a review
from 
singhashish-wpf
requested review from
baronfel,
KirillOsenkov,
rainersigwald and
pchaurasia14
and removed request for
dipeshmsft
rainersigwald
approved these changes
Oct 31, 2023
|
cc:// @dotnet/dotnet-wpf-triage |
|
Hi @singhashish-wpf. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
KirillOsenkov
approved these changes
Oct 31, 2023
Kuldeep-MS
approved these changes
Nov 2, 2023
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/wpf/actions/runs/6801962726 |
|
This won't fix it for people who use desktop WPF, right? |
|
@KirillOsenkov Right. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
dotnet/sdk#34438
Description
Due to SourceLink enabled by default in .NET8, Files related to markup compilation are being embedded with wrong paths.
Turning off EmbedUntrackedSources for GenerateTemporaryTargetAssembly.cs.
Customer Impact
Build fails if the project has
IncludePackageReferencesDuringMarkupCompilationset to false.Customer can set
IncludePackageReferencesDuringMarkupCompilationto true orEmbedUntrackedSourcesas false in csproj as a workaround .Regression
Yes. Started happening in .NET8 Preview 6. Doesn't repro in .net 7
Testing
Local WPF Testing, DRTs and microsuites
Current Test infra of wpf doesn't checks for this case.
Risk
Low. Adding the global property
EmbedUntrackedSourcesduring MarkupCompilation phase. [Still Evaluating]Microsoft Reviewers: Open in CodeFlow