Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build when using source generators coming from NuGet package #6800

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

dipeshmsft
Copy link
Member

@dipeshmsft dipeshmsft commented Jul 14, 2022

Fixes #6792

Description

Fixes build of project using source generators coming from NuGet packages. Added a new target for de-duplicating the list of analyzers.

Added a target to de-duplicate the list of analyzers

Customer Impact

Fixes build.

Regression

This is a regression introduced in .Net 6.0.7 by #6534 which was backported by #6680.

Testing

Tested locally by building a project which uses Regex source generator, WinForms source generator and CommunityToolkit.Mvvm 7.1.2 source generator (This is an example of a source generator that currently fails on .Net 6.0.7 SDK).

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

@dipeshmsft dipeshmsft requested a review from a team as a code owner July 14, 2022 16:14
@ghost ghost assigned dipeshmsft Jul 14, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 14, 2022
@ghost ghost requested review from singhashish-wpf and SamBent July 14, 2022 16:15
@ghost
Copy link

ghost commented Jul 14, 2022

Hi @dipeshmsft. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@rbhanda rbhanda added this to the 6.0.9 milestone Jul 14, 2022
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dipeshmsft dipeshmsft merged commit 6ef7110 into release/6.0 Jul 19, 2022
@dipeshmsft dipeshmsft deleted the srcgen-fix-net6 branch July 19, 2022 05:21
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage Servicing-approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants