[main] Update dependencies from dotnet/winforms #4823

dotnet-maestro · 2021-07-08T13:31:25Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- System.CodeDom: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.Configuration.ConfigurationManager: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.Diagnostics.EventLog: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.DirectoryServices: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.Drawing.Common: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.Reflection.MetadataLoadContext: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.Security.Cryptography.Xml: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.Security.Permissions: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.Windows.Extensions: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.Platforms: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.IO.Packaging: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.ILDAsm: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.ILAsm: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- System.Resources.Extensions: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.App.Ref: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)
- VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms)

From https://github.com/dotnet/winforms

Subscription: dd483b3f-65b0-44ab-f62d-08d8e93a0c51
Build: 20210714.2
Date Produced: 7/14/2021 7:38 PM
Commit: 4c79b345bbe8088fb87192f24b561788519d55d6
Branch: refs/heads/main

Updates:
- Microsoft.Dotnet.WinForms.ProjectTemplates: from 6.0.0-preview.7.21357.9 to 6.0.0-preview.7.21364.2
- Microsoft.Private.Winforms: from 6.0.0-preview.7.21357.9 to 6.0.0-preview.7.21364.2
- System.CodeDom: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.Configuration.ConfigurationManager: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.Diagnostics.EventLog: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.DirectoryServices: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.Drawing.Common: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.Reflection.MetadataLoadContext: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.Security.Cryptography.Xml: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.Security.Permissions: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.Windows.Extensions: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- Microsoft.NETCore.Platforms: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.IO.Packaging: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- Microsoft.NETCore.ILDAsm: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- Microsoft.NETCore.ILAsm: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- System.Resources.Extensions: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- Microsoft.NETCore.App.Ref: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9
- VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-preview.7.21352.2 to 6.0.0-preview.7.21363.9

…10708.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21358.1 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms

…10708.6 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21358.6 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms

…10708.10 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21358.10 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms

RussKie · 2021-07-09T07:36:44Z

The build is failing with hundreds of errors in DirectWriteForwarder.vcxproj like:

D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\TrueTypeSubsetter\truetype.cpp(97): error C2253: 'System::INumber::DivRem': pure specifier or abstract override specifier only allowed on virtual function [D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
##[error]src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\TrueTypeSubsetter\truetype.cpp(97,0): error C2253: (NETCORE_ENGINEERING_TELEMETRY=Build) 'System::INumber::DivRem': pure specifier or abstract override specifier only allowed on virtual function
D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\TrueTypeSubsetter\truetype.cpp(97): message : This diagnostic occurred while importing type 'System::INumber ' from assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. [D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\TrueTypeSubsetter\truetype.cpp(97): message : This diagnostic occurred while importing type 'System::IBinaryNumber ' from assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

…10708.11 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21358.11 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms

…10709.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21359.1 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms

dreddy-work · 2021-07-09T18:08:19Z

@ryalanms , Can you check on this or include right people to take a look and unblock the flow?

dreddy-work · 2021-07-12T18:25:51Z

@SamBent/ @ryalanms , can you help what is wrong here and unblock? Winforms CTI team is blocked on validating latest bits.

ryalanms · 2021-07-12T18:54:17Z

/cc @dotnet/dnr-codeflow

D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\TrueTypeSubsetter\truetype.cpp(97): error C2253: 'System::INumber::DivRem': pure specifier or abstract override specifier only allowed on virtual function [D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
##[error]src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\TrueTypeSubsetter\truetype.cpp(97,0): error C2253: (NETCORE_ENGINEERING_TELEMETRY=Build) 'System::INumber::DivRem': pure specifier or abstract override specifier only allowed on virtual function
D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\TrueTypeSubsetter\truetype.cpp(97): message : This diagnostic occurred while importing type 'System::INumber ' from assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. [D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\DirectWriteForwarder.vcxproj]
D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\DirectWriteForwarder\CPP\TrueTypeSubsetter\truetype.cpp(97): message : This diagnostic occurred while importing type 'System::IBinaryNumber ' from assembly 'System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

…10712.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.1 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms

…10712.2 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.2 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms

dreddy-work · 2021-07-12T22:21:10Z

pinging direct members to get quicker response. @danmoseley, @jeffschwMSFT and @marek-safar

jeffschwMSFT · 2021-07-12T22:30:09Z

@jeffhandley

danmoseley · 2021-07-12T22:31:07Z

this is @tannergooding

tannergooding · 2021-07-12T22:32:13Z

Is this failure in C++/CLI?

jeffhandley · 2021-07-12T22:54:05Z

@danmoseley / @jeffschwMSFT -- Does either of you know a contact on the CPP / CLI team that we can reach out to to explore options for working around this?

danmoseley · 2021-07-12T22:58:47Z

@davidwrighton will know.

jeffhandley · 2021-07-12T23:15:07Z

@ryalanms / @fabiant3 -- This is caused by the introduction of Generic Math in #54650, which uses the new static abstract interface members language feature. From what we can tell, the C++/CLI does not support usage of the language feature (or other new-ish language features) in the primitive types affected.

We are going to explore two mitigation paths:

Disable the Generic Math feature through a dotnet/runtime PR
Determine if this is something the C++/CLI can be updated to accommodate

Obviously, the second option will take time. Disabling Generic Math would still take a few days to flow through. In the meantime, is it reasonable to pin the runtime version used by winforms and/or WPF to the previous version?

tannergooding · 2021-07-12T23:16:05Z

dotnet/runtime#55540 is the runtime side draft PR to disable the generic math feature if we determine that to be necessary until C++/CLI can be updated to accommodate the feature.

jkoritzinsky · 2021-07-12T23:19:22Z

@tgani-msft (MSFT alias tgani) is the C++/CLI contact for .NET Core (or at least was the last time I worked on C++/CLI-related work.

ryalanms · 2021-07-12T23:28:55Z

Obviously, the second option will take time. Disabling Generic Math would still take a few days to flow through. In the meantime, is it reasonable to pin the runtime version used by winforms and/or WPF to the previous version?

Thanks, @jeffhandley. Pinning to the previous version temporarily would be fine for WPF. (winforms and wpf share the same versions of the runtime.)

@merriemcgaw @RussKie @dreddy-work: Can winforms temporarily use an older version of the runtime that does not contain the generic math change (e.g., 6.0.0-preview.7.21352.2)?

dreddy-work · 2021-07-12T23:30:32Z

Obviously, the second option will take time. Disabling Generic Math would still take a few days to flow through. In the meantime, is it reasonable to pin the runtime version used by winforms and/or WPF to the previous version?

Thanks, @jeffhandley. This would be fine for WPF. (winforms and wpf share the same versions of the runtime.)

@merriemcgaw @RussKie @dreddy-work: Can winforms continue to use an older version of the runtime that does not contain the generic math change (e.g., 6.0.0-preview.7.21352.2)?

I do not see any reason why it won't. We did not take any specific dependencies recently for this..

…10712.3 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.3 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21361.10 (parent: Microsoft.Private.Winforms

RussKie · 2021-07-12T23:57:13Z

@dreddy-work please disable the in-flow into the winforms main from runtime using darc for now.

dreddy-work · 2021-07-13T00:01:48Z

@dreddy-work please disable the in-flow into the winforms main from runtime using darc for now.

Can you point me to instruction on where/how we do this?

RussKie · 2021-07-13T00:11:16Z

I'm on a personal machine. Ask in the @dnceng Teams channel or ping @mmitche for help.

…5231)

dreddy-work · 2021-07-13T00:35:05Z

/azp run

azure-pipelines · 2021-07-13T00:35:15Z

Azure Pipelines successfully started running 1 pipeline(s).

RussKie · 2021-07-13T00:36:34Z

Now we need to wait for the winforms downgrade to flow through... ⏳

…10712.4 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.4 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21361.10 (parent: Microsoft.Private.Winforms

…10712.5 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.5 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21352.2 (parent: Microsoft.Private.Winforms

hez2010 · 2021-07-13T03:20:08Z

I think a <EnablePreviewFeatures>true</EnablePreviewFeatures> is required for generic math in current stage, a simple approach is to prevent user setting EnablePreviewFeatures to true while UseWpf = true.

ThomasGoulet73 · 2021-07-13T03:34:34Z

@hez2010 If I understood the problem correctly, the problem is not generic math per se. It's the static interface members which are required for generic math. Also, I think EnablePreviewFeatures only removes the code when using Trimming because the code is still in the ref assembly and I don't think the C++/CLI linker is aware of the feature switches/preview features. Either way, I think that for this to work, the support of static interface members would require modification to C++/CLI to either include the code correctly or to link it away.

hez2010 · 2021-07-13T03:51:45Z

Actually I have no idea about whether it will work for ref assemblies or not...

And of course C++/CLI should add support for consuming virtual static members IMO.

RussKie · 2021-07-13T04:43:04Z

@ryalanms please apply downgrades to 6.0.0-preview.7.21352.2 in this PR

D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\Themes\PresentationFramework.Aero2\PresentationFramework.Aero2.csproj : error NU1605: Detected package downgrade: Microsoft.NETCore.Platforms from 6.0.0-preview.7.21361.10 to 6.0.0-preview.7.21352.2. Reference the package directly from the project to select a different version.  [D:\workspace\_work\1\s\Microsoft.Dotnet.Wpf.sln]
D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\Themes\PresentationFramework.Aero2\PresentationFramework.Aero2.csproj : error NU1605:  PresentationFramework.Aero2 -> Microsoft.Private.Winforms 6.0.0-preview.7.21362.5 -> Microsoft.NETCore.Platforms (>= 6.0.0-preview.7.21361.10)  [D:\workspace\_work\1\s\Microsoft.Dotnet.Wpf.sln]
D:\workspace\_work\1\s\src\Microsoft.DotNet.Wpf\src\Themes\PresentationFramework.Aero2\PresentationFramework.Aero2.csproj : error NU1605:  PresentationFramework.Aero2 -> Microsoft.NETCore.Platforms (>= 6.0.0-preview.7.21352.2) [D:\workspace\_work\1\s\Microsoft.Dotnet.Wpf.sln]
##[error]src\Microsoft.DotNet.Wpf\src\Themes\PresentationFramework.Aero2\PresentationFramework.Aero2.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: Microsoft.NETCore.Platforms from 6.0.0-preview.7.21361.10 to 6.0.0-preview.7.21352.2. Reference the package directly from the project to select a different version.

ryalanms · 2021-07-13T15:46:32Z

@ryalanms please apply downgrades to 6.0.0-preview.7.21352.2 in this PR

D:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\Themes\PresentationFramework.Aero2\PresentationFramework.Aero2.csproj : error NU1605: PresentationFramework.Aero2 -> Microsoft.Private.Winforms 6.0.0-preview.7.21362.5 -> Microsoft.NETCore.Platforms (>= 6.0.0-preview.7.21361.10) [D:\workspace_work\1\s\Microsoft.Dotnet.Wpf.sln]
...

We need to take the same version of the runtme that the winforms package was built against. In this case, 6.0.0-preview.7.21361.10 (for Microsoft.Private.Winforms 6.0.0-preview.7.21362.5).

dreddy-work · 2021-07-13T16:48:27Z

We need to take the same version of the runtme that the winforms package was built against. In this case, 6.0.0-preview.7.21361.10 (for Microsoft.Private.Winforms 6.0.0-preview.7.21362.5).

@ryalanms , winforms did downgrade to 6.0.0-preview.7.21352.2 and dependency flow reached to this PR with commit . Can you clarify on why you see this binary is targeting higher version?

ryalanms · 2021-07-13T17:38:25Z

@dreddy-work: This is the file that needs to be changed in the winforms repo: https://github.com/dotnet/winforms/blob/main/eng/Versions.props

It is targeting 6.0.0-preview.7.21361.10, not 6.0.0-preview.7.21352.2.

Now that there is more time, we should just wait for dotnet/runtime#55540.

/cc @lukas-lansky @tannergooding

…10714.2 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21364.2 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms

dotnet-maestro bot requested a review from a team as a code owner July 8, 2021 13:31

ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 8, 2021

ghost requested review from fabiant3, ryalanms and SamBent July 8, 2021 13:31

RussKie mentioned this pull request Jul 9, 2021

Import Windows Forms related props and targets into Windows Desktop #4779

Merged

dotnet-maestro bot added 2 commits July 9, 2021 08:34

dotnet-maestro bot added 2 commits July 12, 2021 21:28

tannergooding mentioned this pull request Jul 12, 2021

Disable generic math due to C++/CLI incompatibilities dotnet/runtime#55540

Merged

RussKie added a commit to dotnet/winforms that referenced this pull request Jul 12, 2021

Downgrade dotnet/runtime to allow flow of WPF (see dotnet/wpf#4823)

a4781d1

RussKie added a commit to dotnet/winforms that referenced this pull request Jul 13, 2021

Downgrade dotnet/runtime to allow flow of WPF (see dotnet/wpf#4823) (#…

b1225b7

…5231)

dotnet-maestro bot added 2 commits July 13, 2021 00:59

dotnet-maestro bot merged commit cc27b82 into main Jul 14, 2021

dotnet-maestro bot deleted the darc-main-a0a4e9f0-9738-477c-89ac-0b78c61e993e branch July 14, 2021 20:31

ghost locked as resolved and limited conversation to collaborators Apr 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/winforms #4823

[main] Update dependencies from dotnet/winforms #4823

dotnet-maestro bot commented Jul 8, 2021 •

edited

Loading

RussKie commented Jul 9, 2021

dreddy-work commented Jul 9, 2021

dreddy-work commented Jul 12, 2021

ryalanms commented Jul 12, 2021

dreddy-work commented Jul 12, 2021

jeffschwMSFT commented Jul 12, 2021

danmoseley commented Jul 12, 2021

tannergooding commented Jul 12, 2021

jeffhandley commented Jul 12, 2021

danmoseley commented Jul 12, 2021

jeffhandley commented Jul 12, 2021

tannergooding commented Jul 12, 2021

jkoritzinsky commented Jul 12, 2021

ryalanms commented Jul 12, 2021 •

edited

Loading

dreddy-work commented Jul 12, 2021

RussKie commented Jul 12, 2021

dreddy-work commented Jul 13, 2021

RussKie commented Jul 13, 2021

dreddy-work commented Jul 13, 2021

azure-pipelines bot commented Jul 13, 2021

RussKie commented Jul 13, 2021

hez2010 commented Jul 13, 2021 •

edited

Loading

ThomasGoulet73 commented Jul 13, 2021

hez2010 commented Jul 13, 2021 •

edited

Loading

RussKie commented Jul 13, 2021

ryalanms commented Jul 13, 2021

dreddy-work commented Jul 13, 2021

ryalanms commented Jul 13, 2021 •

edited

Loading

[main] Update dependencies from dotnet/winforms #4823

[main] Update dependencies from dotnet/winforms #4823

Conversation

dotnet-maestro bot commented Jul 8, 2021 • edited Loading

Coherency Updates

From https://github.com/dotnet/winforms

RussKie commented Jul 9, 2021

dreddy-work commented Jul 9, 2021

dreddy-work commented Jul 12, 2021

ryalanms commented Jul 12, 2021

dreddy-work commented Jul 12, 2021

jeffschwMSFT commented Jul 12, 2021

danmoseley commented Jul 12, 2021

tannergooding commented Jul 12, 2021

jeffhandley commented Jul 12, 2021

danmoseley commented Jul 12, 2021

jeffhandley commented Jul 12, 2021

tannergooding commented Jul 12, 2021

jkoritzinsky commented Jul 12, 2021

ryalanms commented Jul 12, 2021 • edited Loading

dreddy-work commented Jul 12, 2021

RussKie commented Jul 12, 2021

dreddy-work commented Jul 13, 2021

RussKie commented Jul 13, 2021

dreddy-work commented Jul 13, 2021

azure-pipelines bot commented Jul 13, 2021

RussKie commented Jul 13, 2021

hez2010 commented Jul 13, 2021 • edited Loading

ThomasGoulet73 commented Jul 13, 2021

hez2010 commented Jul 13, 2021 • edited Loading

RussKie commented Jul 13, 2021

ryalanms commented Jul 13, 2021

dreddy-work commented Jul 13, 2021

ryalanms commented Jul 13, 2021 • edited Loading

dotnet-maestro bot commented Jul 8, 2021 •

edited

Loading

ryalanms commented Jul 12, 2021 •

edited

Loading

hez2010 commented Jul 13, 2021 •

edited

Loading

hez2010 commented Jul 13, 2021 •

edited

Loading

ryalanms commented Jul 13, 2021 •

edited

Loading