Community PR test pass 1/4/2021 #3948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect EditorConfig preferences for whitespace and newlines
The MSBuild items & targets that were defined after the WinFX targets import doesn't depend on anything from the WinFX targets. So, it is safe and better to declare the import after those items and targets definitions.
When the SDK's implementation is being used.
Currently there's no way to properly switch between NETFX's and CoreCLR's WinFX targets. This adds an opt-out, just in case, if we want to use the NETFX's WinFX targets instead.
…ty.testpass.1.4.2021
ghost
added
the
ghost
requested review from
|
Apologies for the delay. We have the test results but there are a few failures that appear to be test infrastructure problems on a few OS images. Once these are investigated and re-run, we will get these PRs in. Thanks everyone for your contributions! This process should get faster now that the test team has more capacity for WPF. |
ryalanms
added
the
* NO MERGE *
|
We should merge individual PRs, not the community test pass branch. |
|
All PRs were merged individually. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community PR Test Pass 1/4/2021
These PRs will be merged if no regressions are found. These limited test passes take the team about 24 hours.
Community PRs included in this test branch:
Don't double import WinFX targets #2976
Make CustomGuids as readonly #3907
Using readonly struct in WPF Ink module #3908
Replace the Dictionary with HashSet in AppDomainShutdownMonitor
Special the capacity to improve performance #3086
Use the new Marshal.IsTypeVisibleFromCom Api #3279
Test Matrix