Muti target 5.0 second part #3155
Conversation
In Sdk.props. Set the property so the dotnet core SDK will import it.
ghost
added
the
ghost
requested review from
|
@ryalanms could you review the second part of #2869? It is part of dotnet/sdk#12108 |
| <Import Project="$(WpfSourceDir)PresentationBuildTasks\Microsoft.WinFX.props" | ||
| Condition="Exists('$(LocalMicrosoftWinFXProps)') "/> | ||
|
|
||
| <Import Sdk="Microsoft.NET.Sdk.WindowsDesktop" |
There was a problem hiding this comment.
I am not very sure deleting that is safe. However, after the last change, Microsoft.WinFX.props files is empty
There was a problem hiding this comment.
Did you confirm that this is still picking up the locally built version of PresentationBuildTasks?
There was a problem hiding this comment.
This (the ‘otherwise import Windowsdesktop props’ part) can only be tested by flowing (simulating the flow) the wpf.arcade package to the wpf-int repo, and building a project there that relies on InternalMarkupCompilation. One may not exist there today, but creating a test app that does should be quite easy.
This functionality may important to retain for future use by the test repo.
There was a problem hiding this comment.
I now see that InternalMarkupCompilation isn't set in the WPF repo.
There was a problem hiding this comment.
Sorry, I have no idea what you are talking about. What is the action item here? Can I remove this or not? I could left the empty WinFXProps file if we need it
There was a problem hiding this comment.
@wli3: Can you add the replacement of pbt.props/targets in to your refactoring work issue? Thanks.
There was a problem hiding this comment.
Do you have doc for what pbt.props/targets is for? I did read the binlog of build of wpf repo. But I still don't have a clue
There was a problem hiding this comment.
There is some description in the markdown file. Sorry, I don't believe there is a separate doc with a more detailed description. We can discuss it during the meeting later today. Thanks.
There was a problem hiding this comment.
Do you have any on boarding document that I can read in the meanwhile?
|
Manual tested Sdk="Microsoft.NET.Sdk.WindowsDesktop"
Sdk="Microsoft.NET.Sdk"
And the inner build still uses the pbt just created. |
|
I'm signing off based on the testing you performed we discussed offline. Thanks. |
No description provided.