Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't double import WinFX targets #2976

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Don't double import WinFX targets #2976

merged 4 commits into from
Jan 12, 2021

Commits on Jan 8, 2021

  1. Remove trailing whitespace 

    Respect EditorConfig preferences for whitespace and newlines
    @Nirmal4G
    Nirmal4G committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    699bda2 View commit details
    Browse the repository at this point in the history

  2. Rearrange WinFX import and add comments 

    The MSBuild items & targets that were defined after the WinFX targets import doesn't depend on anything from the WinFX targets.
So, it is safe and better to declare the import after those items and targets definitions.
    @Nirmal4G
    Nirmal4G committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    9edaa39 View commit details
    Browse the repository at this point in the history

  3. Don't import .NET Framework's implementation of WinFX targets 

    When the SDK's implementation is being used.
    @Nirmal4G
    Nirmal4G committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    95fa04f View commit details
    Browse the repository at this point in the history

  4. Make the Framework WinFX targets import opt-out 

    Currently there's no way to properly switch between NETFX's and CoreCLR's WinFX targets.
This adds an opt-out, just in case, if we want to use the NETFX's WinFX targets instead.
    @Nirmal4G
    Nirmal4G committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    4105777 View commit details
    Browse the repository at this point in the history