Enable BinSkim scan in nightly validation #9467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
dreddy-work
approved these changes
Jul 11, 2023
|
@merriemcgaw as FYI. |
|
@MilenaHristova, where do we see failures ( if any) on these nightly runs? |
There will be issues created in https://devdiv.visualstudio.com/DevDiv/_workitems/ for each bug/problem and the recipients that are configured will get an email (for you its wffteam@microsoft.com) |
|
@MilenaHristova - how often will the tests be run? |
Every day - binskim ran yesterday https://dev.azure.com/dnceng/internal/_build/results?buildId=2220644&view=logs&j=5670356f-8b38-5a32-2003-b78bdacf9625&t=4f4f7d31-42fc-5115-60ca-d0d4ff387d46 and found no issues for winforms |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enabling BinSkim scan over build artifacts in Validate-DotNet pipeline and the .NET staging pipeline based on company requirements.
We are required to run SDL tools on official builds and implement automated bug filling for the tools output. Currently we are running SDL checks over the source code in the nightly builds and in the .NET staging pipeline, but to be compliant we need to also run BinSkim over the produced artifacts.
This PRs is enabling BinSkim checks in the nightly run of Validate-DotNet pipeline.
More information is in the Automate BinSkim runs over official builds issue
Customer Impact No
Regression? No
Risk No
Microsoft Reviewers: Open in CodeFlow