Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for ToolStrip #3994

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

JeremyKuhne
Copy link
Member

@JeremyKuhne JeremyKuhne commented Sep 24, 2020

Adds basic clipping support to the EMF validation system and a validation test for the background rendering of ToolStrip.

Microsoft Reviewers: Open in CodeFlow

Adds basic clipping support to the EMF validation system and a validation test for the background rendering of ToolStrip.
@JeremyKuhne JeremyKuhne added this to the 6.0 Preview1 milestone Sep 24, 2020
@JeremyKuhne JeremyKuhne requested a review from a team as a code owner September 24, 2020 01:48
@JeremyKuhne JeremyKuhne self-assigned this Sep 24, 2020
@JeremyKuhne
Copy link
Member Author

Related to fix for #3975

@RussKie
Copy link
Member

RussKie commented Sep 24, 2020

There's a bunch of failing TextRendererTests tests

@RussKie RussKie added the 📭 waiting-author-feedback The team requires more information from the author label Sep 24, 2020
@JeremyKuhne
Copy link
Member Author

Ugh, and no call stacks for the failures or anything useful in the artifacts. Looking.

@ghost ghost removed the 📭 waiting-author-feedback The team requires more information from the author label Sep 24, 2020
@JeremyKuhne
Copy link
Member Author

Release failed for #3456

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with a suggestion

@JeremyKuhne JeremyKuhne merged commit 548ab3a into dotnet:master Sep 25, 2020
@RussKie RussKie added the test-enhancement Improvements of test source code label Sep 25, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants