-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for ToolStrip #3994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds basic clipping support to the EMF validation system and a validation test for the background rendering of ToolStrip.
Related to fix for #3975 |
There's a bunch of failing |
RussKie
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Sep 24, 2020
Ugh, and no call stacks for the failures or anything useful in the artifacts. Looking. |
ghost
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Sep 24, 2020
Release failed for #3456 |
This was referenced Sep 24, 2020
RussKie
reviewed
Sep 25, 2020
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripTests.Rendering.cs
Show resolved
Hide resolved
RussKie
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 with a suggestion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic clipping support to the EMF validation system and a validation test for the background rendering of ToolStrip.
Microsoft Reviewers: Open in CodeFlow