[main] Update dependencies from dotnet/arcade #12985
Conversation
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
![dotnet-policy-service[bot]](https://avatars.githubusercontent.com/in/285228?s=60&v=4){kind=small}
…219.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.25113.2 -> To Version 10.0.0-beta.25119.2
Tanya-Solyanik
force-pushed
the
darc-main-77361d96-8477-40aa-a060-1fb470bc36db
branch
from
4a8c977 to
58ba846
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12985 +/- ##
===================================================
+ Coverage 74.86693% 76.01612% +1.14919%
===================================================
Files 3267 3267
Lines 643459 643428 -31
Branches 47432 47428 -4
===================================================
+ Hits 481738 489109 +7371
+ Misses 152932 150763 -2169
+ Partials 8789 3556 -5233
Flags with carried forward coverage won't be shown. Click here to find out more. |
| // if the container is a form and it has autoscroll turned on, we allow a drag beyond the | ||
| // container boundary on the width and height, but not top and left. | ||
| // | ||
| bool containerSelected = false; |
There was a problem hiding this comment.
This is quite the chunk of dead code. I double checked the .NET Framework source (INTERNAL), and it does, in fact, not do anything.
That said, GetComponent, GetControl, and GetCurrentSnapSize are all virtual, so removing this has some risk.
There was a problem hiding this comment.
Yes, it is present in all versions of System.Design. I don't see what problem it intended to solve, looks like a copy/paste from the design surface selection code, so I'll remove it from the OOP designer's server. as well.
The virtual methods are defined on an internal class, I checked out our implementations, they don't have side effects.
dotnet-maestro
bot
deleted the
darc-main-77361d96-8477-40aa-a060-1fb470bc36db
branch
[main] Update dependencies from dotnet/arcade - Fixes dotnet#12881 - Fixed instances of IDE0059 - False positive case of IDE0059, fix is on the way dotnet/roslyn#77297
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Microsoft Reviewers: Open in CodeFlow