Fill missing information in resource files so they can be loaded correctly #12708
Conversation
…ectly. Fixes dotnet#12686 ## Root Cause - Missing information in resource files prevents them from loading. ## Proposed changes - Fill missing information in resource files so they can be loaded correctly. ## Customer Impact - None ## Regression? - No ## Risk - Minimal ## Screenshots ### Before ### After ## Test methodology - Manual ## Test environment(s) - `10.0.100-alpha.1.24573.1`
|
Drafting this PR because I haven't been able to load resources for @LeafShi1 @Epica3055 @lonitra @Tanya-Solyanik – Do you have any insights on what might be missing here? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12708 +/- ##
===================================================
+ Coverage 76.00638% 76.03702% +0.03064%
===================================================
Files 3181 3181
Lines 639670 639670
Branches 47215 47215
===================================================
+ Hits 486190 486386 +196
+ Misses 149968 149771 -197
- Partials 3512 3513 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
I can open it normally on my side. Do you get any errors? |
| @@ -127,7 +127,7 @@ | |||
| <value>0</value> | |||
| </data> | |||
| <data name="byteViewer.Text"> | |||
| <value /> | |||
| <value xml:space="preserve">0</value> | |||
There was a problem hiding this comment.
This is not an equivalent change, we had a null test before and we have a "0" as a test now... I think that the empty value cases are a bug in the new resource designer. We shouldn't fix them.
There was a problem hiding this comment.
I added some comments to the issue
Tanya-Solyanik
added
the
📭 waiting-author-feedback
Fixes #12686
Root Cause
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Test methodology
Test environment(s)
10.0.100-alpha.1.24573.1Microsoft Reviewers: Open in CodeFlow