Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all Clipboard related tests to a new class and remove SkipOnArchitecture label #11606

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jun 28, 2024

Related #11227

Proposed changes

  • Move all Clipboard related tests to a new class and remove SkipOnArchitecture label
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56461%. Comparing base (b3b877e) to head (c78800e).
Report is 13 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11606         +/-   ##
===================================================
+ Coverage   74.56266%   74.56461%   +0.00195%     
===================================================
  Files           3040        3041          +1     
  Lines         629551      629493         -58     
  Branches       46854       46835         -19     
===================================================
- Hits          469410      469379         -31     
+ Misses        156784      156750         -34     
- Partials        3357        3364          +7     
Flag Coverage Δ
Debug 74.56461% <100.00000%> (+0.00195%) ⬆️
integration 17.97987% <ø> (-0.01427%) ⬇️
production 47.49228% <ø> (-0.02751%) ⬇️
test 96.97886% <100.00000%> (+0.02177%) ⬆️
unit 44.52792% <ø> (-0.02846%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@LeafShi1 LeafShi1 requested a review from lonitra June 28, 2024 07:13
@paul1956
Copy link
Contributor

paul1956 commented Jun 28, 2024 via email

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label Jun 28, 2024
Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik
Copy link
Member

@paul1956 - could you please describe the conflict?

but that will conflict/clash with this PR.

@paul1956
Copy link
Contributor

paul1956 commented Jun 28, 2024 via email

@LeafShi1
Copy link
Member Author

LeafShi1 commented Jul 1, 2024

Sent from my iPhoneI apologize for any typos Siri might have made.(503) 803-6077On Jun 28, 2024, at 11:03 AM, Tanya Solyanik @.> wrote: @paul1956 - could you please describe the conflict? but that will conflict/clash with this PR.I will merge your changes and see what happens then I will know more.  What I know now is none of the new and existing Visual Basic Runtime Clipboard/ClopboardProxy tests are in your new project and most are written in VB. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>

Ok, I will keep this PR open.

@Tanya-Solyanik
Copy link
Member

and existing Visual Basic Runtime Clipboard/ClopboardProxy tests are in your new project and most are written in VB.

@paul1956 - I don't think this is a problem, we are not synchronizing tests from different assemblies in this PR. This PR adds some clipboard related tests to the synchronized collection within a single test assembly. There might be some other tests that we hadn't added yet, for example in the datagridview area.

@Tanya-Solyanik Tanya-Solyanik added ready-to-merge PRs that are ready to merge but worth notifying the internal team. and removed waiting-review This item is waiting on review by one or more members of team labels Jul 8, 2024
@paul1956
Copy link
Contributor

paul1956 commented Jul 9, 2024

@Tanya-Solyanik I looked into this more and I handle "synchronizing tests from different assemblies" for the VB tests. I will test to verify issue is fixed once you merge.
Thanks.

@lonitra lonitra merged commit f32de31 into dotnet:main Jul 9, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview7 milestone Jul 9, 2024
@dotnet-policy-service dotnet-policy-service bot removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Jul 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
@LeafShi1 LeafShi1 deleted the Move_Clipboard_tests_NewClass branch August 20, 2024 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants