Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable skipped test: ImageList_FinalizerReleasesNativeHandle_ReturnsExpected #6635

Closed
Tracked by #6690 ...
vladimir-krestov opened this issue Feb 7, 2022 · 1 comment · Fixed by #10555
Closed
Tracked by #6690 ...
Labels
test-bug Problem in test source code (most likely)

Comments

@vladimir-krestov
Copy link
Contributor

  • .NET Core Version: 7.0
  • Have you experienced this same bug with .NET Framework?: No

Problem description:

  • ImageList_FinalizerReleasesNativeHandle_ReturnsExpected unit test fails sometime in x86 Debug CI build for successful PRs, that blocking deployment of fixes into sdk.

Stack trace (System.Windows.Forms.UI.IntegrationTests_net7.0_x86.log)

System.Windows.Forms.UITests.ImageListTests.ImageList_FinalizerReleasesNativeHandle_ReturnsExpected [FAIL]
      Assert.Equal() Failure
      Expected: 32
      Actual:   31
      Stack Trace:
        /_/src/System.Windows.Forms/tests/IntegrationTests/UIIntegrationTests/ImageListTests.cs(47,0): at System.Windows.Forms.UITests.ImageListTests.ImageList_FinalizerReleasesNativeHandle_ReturnsExpected()
      Output:
        GDI handles before: 32
        GDI handles after: 31

Expected behavior:

  • All correct tests pass every time.

Minimal repro:

  • Run unit tests on x86 environment (or create a PR with changes, CI build will do it)
@vladimir-krestov vladimir-krestov added the test-bug Problem in test source code (most likely) label Feb 7, 2022
@Tanya-Solyanik Tanya-Solyanik changed the title ImageList_FinalizerReleasesNativeHandle_ReturnsExpected test is flaky in x86 Debug CI build Re-enable skipped test: ImageList_FinalizerReleasesNativeHandle_ReturnsExpected Jul 15, 2022
@dreddy-work
Copy link
Member

This is still an issue after #8772. Keeping it disabled to investigate further.

@ghost ghost added the 🚧 work in progress Work that is current in progress label Dec 29, 2023
sharwell added a commit to sharwell/winforms that referenced this issue Dec 29, 2023
sharwell added a commit to sharwell/winforms that referenced this issue Dec 29, 2023
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Dec 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants