Make SecureConversation inner channel factory share the same HttpClient as outer factory #4438
+51
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenMolloy
requested changes
Nov 21, 2020
src/System.Private.ServiceModel/src/System/ServiceModel/Channels/HttpTransportBindingElement.cs
Show resolved
Hide resolved
src/System.Private.ServiceModel/src/Internals/System/Runtime/MruCache.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 2 commits
December 16, 2020 13:17
mconnew
force-pushed
the
ShareHttpClientSCT
branch
from
4d25472 to
6e49069
Compare
|
@StephenMolloy, can you review the latest changes? |
HongGit
reviewed
Jan 7, 2021
src/System.Private.ServiceModel/src/System/ServiceModel/Channels/HttpTransportBindingElement.cs
Show resolved
Hide resolved
HongGit
added a commit
that referenced
this pull request
Jan 14, 2021
#4492) * update arcade in release/3.2 branch and cherry-pick one more checkin from master * Make SecureConversation inner channel factory share the same HttpClient as outer factory (#4438) * Make SecureConversation inner channel factory share the same HttpClient as outer factory * Fix lock semantics ref counting in mrucache Co-authored-by: Matt Connew <matt.connew@microsoft.com> Co-authored-by: Matt Connew <mconnew@microsoft.com> Co-authored-by: Matt Connew <matt.connew@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SecureConversation, an inner channel factory is used to obtain the Secure Conversation token. When using a load balancer, this can result in the session establishment and service request being made to different backend hosts resulting in the service call failing.