Modifications to sync with M.IM.WsTrust. #4398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tablishSecurityContext to control SCT bootstrap Remove Target and EstablishSecurityContest properties from WSTrustTokenParameters Use DiagnosticUtility to trace exceptions Remove M.IM.Logging direct dependency Add comments to Federation classes Format comments using InvariantCulture
mconnew
reviewed
Oct 16, 2020
| @@ -21,13 +18,13 @@ public class WSTrustChannelSecurityTokenManager : ClientCredentialsSecurityToken | |||
| private WSTrustChannelClientCredentials _wsTrustChannelClientCredentials; | |||
|
|
|||
| /// <summary> | |||
| /// | |||
| /// Instaintiates a <see cref="WSTrustChannelSecurityTokenManager"/>. | |||
| /// </summary> | |||
There was a problem hiding this comment.
fixed in: 9a8f277
mconnew
reviewed
Oct 16, 2020
| @@ -27,7 +24,8 @@ namespace System.ServiceModel.Federation | |||
| { | |||
|
|
|||
| /// <summary> | |||
| /// Custom WSTrustChannelSecurityTokenProvider that returns a SAML assertion | |||
| /// <see cref="WSTrustChannelSecurityTokenProvider"/> has been designed to work with <see cref="WSFederationHttpBinding"/> to that will send a WsTrust message to obtain a token from an STS and add the token as | |||
| /// an issued token when communicating with a WCF relying party. | |||
There was a problem hiding this comment.
I think you merged two different phrases in your head. "to that will send" doesn't make sense.
There was a problem hiding this comment.
fixed in: 9a8f277
mconnew
reviewed
Oct 16, 2020
|
|
||
| /// <summary> | ||
| /// Values that are used to obtain a token from an IdentityProvider | ||
| /// Instantiates aa <see cref="wsTrustTokenParameters"/> that describe the parameters for a WSTrust request. | ||
| /// </summary> |
There was a problem hiding this comment.
fixed in: 9a8f277
mconnew
reviewed
Oct 16, 2020
| @@ -32,7 +32,6 @@ public static void WSFederationHttpBindingTests_Succeeds() | |||
| { | |||
| // *** SETUP *** \\ | |||
| issuerAddress = new EndpointAddress(new Uri(Endpoints.WSFederationAuthorityLocalSTS)); | |||
| tokenTargetAddress = Endpoints.Https_SecModeTransWithMessCred_ClientCredTypeIssuedTokenSaml2; | |||
| serviceEndpointAddress = new EndpointAddress(new Uri(tokenTargetAddress)); | |||
There was a problem hiding this comment.
This broke the test as it's used on the next line to create the serviceEndpointAddress.
There was a problem hiding this comment.
fixed in: 9a8f277
Check for WSTrustParameters as IssuedSecurityTokenParameters in ctor of WSTrustChannelSecurityTokenProvider Use DiagnosticUtility when throwing
|
I don't know how this build on the PR machine. I cloned your repo locally and I'm getting lots of errors on the restore step. |
|
I found the source of the errors. Apparently our build system removes nuget.org as a package source when the tests are targeting .net5. This only affects local building as the package restore is done differently for our PR and CI system. |
|
Closing in preference of #4400 which contains all these commits. |
|
@mconnew thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WSFederationHttpBinding.CreateMessgeSecurity uses Security.Message.EstablishSecurityContext to control SCT bootstrap
Remove Target and EstablishSecurityContest properties from WSTrustTokenParameters
Use DiagnosticUtility to trace exceptions
Remove M.IM.Logging direct dependency
Add comments to Federation classes
Format comments using InvariantCulture