Disable Prettier if no prettier config exists #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of users of [prettier extension](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) use it to format files automatically on save leading to unwanted diffs, so I've added an option to disable prettier unless there is a prettier config file.
Codecov Report
@@ Coverage Diff @@
## master #3994 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 60 60
Lines 1852 1852
Branches 214 214
=======================================
Hits 1592 1592
Misses 200 200
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@muhammadsammy Seems reasonable. Thanks for submitting. |
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of users of prettier extension use it to format files automatically on save leading to unwanted diffs, so I've added an option to disable prettier unless there is a prettier config file.