Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for different omnisharp "engines" #3817

Merged
merged 30 commits into from
Jun 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
41026c3
Added lsp driver
david-driscoll Aug 22, 2020
bf06442
split engines out from server
david-driscoll Aug 23, 2020
679824c
Merge remote-tracking branch 'origin/master' into feature/lsp-engine
david-driscoll Nov 8, 2020
ccd0917
some test updates to where things pass, but it looks like some messag…
david-driscoll Nov 9, 2020
9238139
Merge remote-tracking branch 'origin/master' into feature/lsp-engine
david-driscoll Dec 16, 2020
5968224
Rebased against master
david-driscoll Dec 16, 2020
55d7386
fixed all but 5 tests
david-driscoll Dec 16, 2020
ecaa581
Merge remote-tracking branch 'origin/master' into feature/lsp-engine
david-driscoll Dec 16, 2020
018ff4f
remove index adjustment from change forwarder
david-driscoll Dec 16, 2020
1d5b45c
Updated lsp engine branch
david-driscoll Jan 24, 2021
eec2526
Removed extra code
david-driscoll Jan 24, 2021
d80624e
Merge remote-tracking branch 'origin/feature/lsp-engine' into feature…
david-driscoll Jan 24, 2021
e1e716e
Correct lint warnings.
333fred Jan 24, 2021
8931986
Enable CodeActions via LSP to resolve cancellations in tests.
333fred Jan 25, 2021
05807a2
Merge pull request #4363 from 333fred/feature/lsp-engine
david-driscoll Jan 26, 2021
0d88713
Temp
333fred Jan 27, 2021
08b2e82
Updated semantic token tests to check if the extension was active, be…
david-driscoll Jan 28, 2021
c887a4e
Fix diagnostic provider tests
333fred Jan 28, 2021
1978b5a
restore currrent word, this was not a zero indices behavior
david-driscoll Jan 28, 2021
aacb8e3
Merge remote-tracking branch '333fred/diagnostic-provider-tests' into…
david-driscoll Jan 29, 2021
fb2fee4
fixed null ref error in stdio engine:
david-driscoll Jan 29, 2021
e328513
Disabled razor pages test app (not sure why it isn't working)
david-driscoll Feb 1, 2021
4d1a510
Re-enable the razor tests. Move the razor project back to netcoreapp2…
333fred Feb 1, 2021
c11d71d
Merge pull request #4371 from 333fred/enable-razor
david-driscoll Feb 2, 2021
bf3cb09
Merge branch 'master' into feature/lsp-engine
david-driscoll Feb 4, 2021
e4b8da2
Merge branch 'master' into feature/lsp-engine
david-driscoll Feb 6, 2021
e36b46d
Ensure debug flag is set in debug mode
david-driscoll Feb 7, 2021
4ba6f1f
Attempted to fix lsp engine to boot with mono correctly
david-driscoll Feb 25, 2021
ddc2c8c
Merge remote-tracking branch 'origin/master' into feature/lsp-engine
david-driscoll Feb 25, 2021
f5e3025
updated encoding when using lsp
david-driscoll Feb 28, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"singleQuote": true
}
81 changes: 78 additions & 3 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
"CODE_TESTS_PATH": "${workspaceRoot}/out/test/integrationTests",
"CODE_TESTS_WORKSPACE": "${workspaceRoot}/test/integrationTests/testAssets/singleCsproj",
"CODE_EXTENSIONS_PATH": "${workspaceRoot}",
"OSVC_SUITE": "singleCsproj"
"OSVC_SUITE": "singleCsproj",
"OMNISHARP_DRIVER": "stdio"
},
"stopOnEntry": false,
"sourceMaps": true,
Expand All @@ -101,7 +102,8 @@
"CODE_TESTS_PATH": "${workspaceRoot}/out/test/integrationTests",
"CODE_TESTS_WORKSPACE": "${workspaceRoot}/test/integrationTests/testAssets/BasicRazorApp2_1",
"CODE_EXTENSIONS_PATH": "${workspaceRoot}",
"OSVC_SUITE": "BasicRazorApp2_1"
"OSVC_SUITE": "BasicRazorApp2_1",
"OMNISHARP_DRIVER": "stdio"
},
},
{
Expand All @@ -120,7 +122,80 @@
"CODE_TESTS_PATH": "${workspaceRoot}/out/test/integrationTests",
"CODE_TESTS_WORKSPACE": "${workspaceRoot}/test/integrationTests/testAssets/slnWithCsproj",
"CODE_EXTENSIONS_PATH": "${workspaceRoot}",
"OSVC_SUITE": "slnWithCsproj"
"OSVC_SUITE": "slnWithCsproj",
"OMNISHARP_DRIVER": "stdio"
},
"stopOnEntry": false,
"sourceMaps": true,
"outFiles": [
"${workspaceRoot}/dist/*.js"
],
"preLaunchTask": "buildDev"
},
{
"name": "Launch singleCsproj Workspace Tests [LSP]",
"type": "extensionHost",
"request": "launch",
"runtimeExecutable": "${execPath}",
"args": [
"--disable-extensions",
"${workspaceRoot}/test/integrationTests/testAssets/singleCsproj",
"--extensionDevelopmentPath=${workspaceRoot}",
"--extensionTestsPath=${workspaceRoot}/out/test/integrationTests"
],
"env": {
"CODE_WORKSPACE_ROOT": "${workspaceRoot}",
"CODE_TESTS_PATH": "${workspaceRoot}/out/test/integrationTests",
"CODE_TESTS_WORKSPACE": "${workspaceRoot}/test/integrationTests/testAssets/singleCsproj",
"CODE_EXTENSIONS_PATH": "${workspaceRoot}",
"OSVC_SUITE": "singleCsproj",
"OMNISHARP_DRIVER": "lsp"
},
"stopOnEntry": false,
"sourceMaps": true,
"outFiles": [
"${workspaceRoot}/dist/*.js"
],
"preLaunchTask": "buildDev"
},
{
"name": "Launch razorcsproj Workspace Tests [LSP]",
"type": "extensionHost",
"request": "launch",
"runtimeExecutable": "${execPath}",
"args": [
"--disable-extensions",
"${workspaceRoot}/test/integrationTests/testAssets/BasicRazorApp2_1",
"--extensionDevelopmentPath=${workspaceRoot}",
"--extensionTestsPath=${workspaceRoot}/out/test/integrationTests"
],
"env": {
"CODE_WORKSPACE_ROOT": "${workspaceRoot}",
"CODE_TESTS_PATH": "${workspaceRoot}/out/test/integrationTests",
"CODE_TESTS_WORKSPACE": "${workspaceRoot}/test/integrationTests/testAssets/BasicRazorApp2_1",
"CODE_EXTENSIONS_PATH": "${workspaceRoot}",
"OSVC_SUITE": "BasicRazorApp2_1",
"OMNISHARP_DRIVER": "lsp"
},
},
{
"name": "Launch slnWithCsproj Workspace Tests [LSP]",
"type": "extensionHost",
"request": "launch",
"runtimeExecutable": "${execPath}",
"args": [
"--disable-extensions",
"${workspaceRoot}/test/integrationTests/testAssets/slnWithCsproj",
"--extensionDevelopmentPath=${workspaceRoot}",
"--extensionTestsPath=${workspaceRoot}/out/test/integrationTests"
],
"env": {
"CODE_WORKSPACE_ROOT": "${workspaceRoot}",
"CODE_TESTS_PATH": "${workspaceRoot}/out/test/integrationTests",
"CODE_TESTS_WORKSPACE": "${workspaceRoot}/test/integrationTests/testAssets/slnWithCsproj",
"CODE_EXTENSIONS_PATH": "${workspaceRoot}",
"OSVC_SUITE": "slnWithCsproj",
"OMNISHARP_DRIVER": "lsp"
},
"stopOnEntry": false,
"sourceMaps": true,
Expand Down
10 changes: 3 additions & 7 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,19 @@
"editor.tabSize": 4,
"editor.insertSpaces": true,
"prettier.requireConfig": true,

"files.exclude": {
"out": true,
"typings": false,
"vsix": true
},

"search.exclude": {
"**/node_modules": true,
"out/": true,
"vsix/": true
},

"csharp.suppressDotnetRestoreNotification": true,

"tslint.rulesDirectory": "node_modules/tslint-microsoft-contrib",
"typescript.tsdk": "./node_modules/typescript/lib",
"mocha.enabled": true,
"omnisharp.autoStart": false
}
"omnisharp.autoStart": false,
"editor.formatOnSave": false
}
Loading