Re-Analyze project or all projects #3089
Conversation
…omnisharp-vscode into feature/analyze-commands
Codecov Report
@@ Coverage Diff @@
## master #3089 +/- ##
==========================================
- Coverage 89.81% 89.74% -0.08%
==========================================
Files 59 59
Lines 1591 1599 +8
Branches 89 89
==========================================
+ Hits 1429 1435 +6
- Misses 151 153 +2
Partials 11 11
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3089 +/- ##
==========================================
- Coverage 89.81% 89.74% -0.08%
==========================================
Files 59 59
Lines 1591 1599 +8
Branches 89 89
==========================================
+ Hits 1429 1435 +6
- Misses 151 153 +2
Partials 11 11
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3089 +/- ##
=========================================
+ Coverage 89.69% 89.8% +0.11%
=========================================
Files 58 59 +1
Lines 1572 1589 +17
Branches 89 89
=========================================
+ Hits 1410 1427 +17
Misses 151 151
Partials 11 11
Continue to review full report at Codecov.
|
|
Why isn't a diagnostic event listener implemented? |
It's actually part of LSP implementation i think. It's definetly possible to use those events to sync state of diagnostics between client and server, however i don't think it's in scope of this PR. CC @david-driscoll @mholo65 can you give better insights of that part @kurobon-jp mentioned? Could it be good idea to consume those events in vscode or should it move LSP directly instead when that is fully ready? |
|
I think it makes sense apart from including implementation in this PR. Analyzing thousands of lines of document in Omnisharp can take several seconds. This allows users to quickly get important diagnostic results. |
src/features/diagnosticsProvider.ts
Outdated
|
|
||
| // On large workspaces (if maxProjectFileCountForDiagnosticAnalysis) is less than workspace size, | ||
| // diagnostic fallback to mode where only open documents are analyzed. | ||
| private _validateLargeWorkspace(): NodeJS.Timeout { |
There was a problem hiding this comment.
I feel like the name _validateOpenDocuments is more meaningful here.
src/features/diagnosticsProvider.ts
Outdated
| if (this._projectValidation) { | ||
| this._projectValidation.cancel(); | ||
| } | ||
| private _validateSmallWorkspace(): NodeJS.Timeout { |
There was a problem hiding this comment.
I feel like the name _validateEntireWorkspace is more meaningful here.
| await activateCSharpExtension(); | ||
| await testAssetWorkspace.restore(); |
There was a problem hiding this comment.
I noticed this reordering of activation and workspace restore in the tests and was curious. What problem is this solving?
There was a problem hiding this comment.
Don't remember for sure. Its possible that this change is unnecessary since i think latter one where i changed tests to use real restore eventing instead of dummy one was root cause for issues with workspace restore instability during tests.
|
Broken atm, probably i missed something at merge. I will fix this during upcoming week. |
|
@JoeRobich i think all concerns fixed now and merge done. |
|
@savpek Thanks! |
VScode implementation for OmniSharp/omnisharp-roslyn#1507
Detailed information in OmniSharp/omnisharp-roslyn#1507