code clean up #1917
Merged
code clean up #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved local functions to top for readability and fixed missing semicolon local function at the end tslint exception for chai
|
|
test/unitTests/common.test.ts
Outdated
| @@ -72,24 +72,28 @@ suite("Common", () => { | |||
| test("same paths", () => { | |||
| let subfolder: string = ["C:", "temp", "VS", "dotnetProject"].join(path.sep); | |||
| let folder: string= ["C:", "temp", "VS", "dotnetProject"].join(path.sep); | |||
| // tslint:disable-next-line:no-unused-expression | |||
There was a problem hiding this comment.
Can this be done more generally? https://www.npmjs.com/package/tslint-no-unused-expression-chai perhaps?
TheRealPiotrP
approved these changes
Dec 11, 2017
|
@TheRealPiotrP was looking into the package and missed the gulp file. now is using the module you point out. |
TheRealPiotrP
approved these changes
Dec 11, 2017
akshita31
pushed a commit
to akshita31/omnisharp-vscode
that referenced
this pull request
Dec 15, 2017
* moved local functions moved local functions to top for readability and fixed missing semicolon local function at the end tslint exception for chai * use genral tslint chai rules * fix path to custom chai rules * revert type package versions * simplify gulp file * force chai types to 4.0.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing semicolon
local functions moved at the end of test suite
tslint exception for chai assertions