Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activation events for *.csproj and *.sln #1592

Merged
merged 3 commits into from
Jun 29, 2017
Merged

Add activation events for *.csproj and *.sln #1592

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77fdef1
Add activation events for *.csproj and *.sln
DustinCampbell Jun 26, 2017
a002b8c
Add activation event for .csx
DustinCampbell Jun 27, 2017
a7f607b
Add activation events with glob patterns to search subfolders
DustinCampbell Jun 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,9 @@
"onCommand:csharp.downloadDebugger",
"onCommand:csharp.listProcess",
"onCommand:csharp.listRemoteProcess",
"workspaceContains:project.json"
"workspaceContains:project.json",
"workspaceContains:*.csproj",
Copy link
Contributor

@eamodio eamodio Jun 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DustinCampbell
I'm not 100% sure, but should those be workspaceContains:**/*.csproj so that it could be in any folder? It may already be handled though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally didn't do that but I'm open to discussing it. I feared that this might be a bit invasive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah -- personally I would definitely want that. We typically open vscode to the root of the repository, and it doesn't have any projects or anything in it -- they are all nested under sub-folders. What are the cases you are thinking about where you wouldn't want that behavior?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of scenarios like the one described by #1328.

"workspaceContains:*.sln"
],
"contributes": {
"configuration": {
Expand Down