Implemented "Go to Implementation" and "Peek Implementation" #1222
Conversation
ivanz
force-pushed
the
goto-implementation
branch
from
5b152a5 to
21bd908
Compare
CHANGELOG.md
Outdated
| @@ -1,6 +1,13 @@ | |||
| ## 1.8.0 _(Not Yet Released)_ | |||
|
|
|||
| ### Code Actions | |||
There was a problem hiding this comment.
Also, I wouldn't put this under "Code Actions". Those are for code fixes and refactorings that appear in the light bulb menu. I'd actually give this it's own subheading: "Go to Implementation".
CHANGELOG.md
Outdated
| ## 1.7.0 (February 8, 2017) | ||
|
|
||
| #### Syntax Hightlighting | ||
| ### Syntax Hightlighting |
There was a problem hiding this comment.
Please don't change this
| export default class CSharpImplementationProvider extends AbstractSupport implements ImplementationProvider { | ||
| constructor(server) { | ||
| super(server); | ||
| } |
There was a problem hiding this comment.
Is this strictly needed if you're just calling super?
CHANGELOG.md
Outdated
|
|
||
| ### Code Actions | ||
|
|
||
| * Support for "Go to Implementation" and "Peek Implementation". ([#37](https://github.com/OmniSharp/omnisharp-vscode/issues/37)) _(Contributed by [@ivanz](https://github.com/ivanz))_ |
|
Fantastic @ivanz! :smile; I'll be back in a couple of hours. If you want to make those small changes to the changelog I requested, I'll merge when I'm back. |
ivanz
force-pushed
the
goto-implementation
branch
from
21bd908 to
ac3dbdf
Compare
|
Updated :) |
|
Thanks again @ivanz. You rock! |
|
Awesome stuff!? Is there a CI build to try this out? |
|
No, we don't push CI builds. I'll need to create a beta release, which I was going to take a look at shortly. I need to get an omnisharp-roslyn build first to ensure that other recently-fixed issues are included in the first 1.8 beta build. |
|
Cool. No worries |
Closes #37