Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ArcGIS Maps SDK mappings #1572

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Adds ArcGIS Maps SDK mappings #1572

merged 4 commits into from
Jun 20, 2024

Conversation

dotMorten
Copy link
Contributor

@dotMorten dotMorten commented Jun 20, 2024

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

For PRs which target a specific extension within UA, changes won't be approved by a member of the dotnet-upgrade-assistant-admin group until a member of the code owners of the extension has approved, when required.

Description

Adds upgrade support for the ArcGIS Maps SDK for .NET helping Xamarin Migration to .NET MAUI

@dotMorten dotMorten requested a review from a team as a code owner June 20, 2024 20:34
jstedfast
jstedfast previously approved these changes Jun 20, 2024
@jstedfast
Copy link
Member

The first API/Package map contribution! Exciting!

@jstedfast
Copy link
Member

Looks like the tests failed:

Assert.IsFalse failed. `Esri\Esri.ArcGISRuntime.Xamarin.Forms\esri.arcgisruntime.xamarin.forms.apimap.json' - ["Esri.ArcGISRuntime.ARToolkit.Forms"]["value"] cannot be empty.

That's on line 17 (the NotImplemented API). Let me poke Anton about that and see if perhaps my tests are wrong or what the value property should be in this case.

@dotMorten
Copy link
Contributor Author

dotMorten commented Jun 20, 2024

Already fixed - The doc made me think it should be empty, but I just removed the entry. Test passing for me. Rookie mistake not running those first

@jstedfast
Copy link
Member

Already fixed - The doc made me think it should be empty, but I just removed the entry.

Excellent. I see you also fixed the other empty values. 👍

@jstedfast jstedfast merged commit 14aba66 into dotnet:main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants