Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for API and Package mappings #1555

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

jstedfast
Copy link
Member

Description

Adds support for 3rd-party API and Package mappings.

@jstedfast jstedfast requested review from a team as code owners April 26, 2024 18:42
@abpiskunov
Copy link
Contributor

not needed


Refers to: src/Microsoft.UpgradeAssistant.Mappings/Microsoft.UpgradeAssistant.Mappings.csproj:30 in 6f6cbb7. [](commit_id = 6f6cbb7, deletion_comment = False)

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@abpiskunov
Copy link
Contributor

<Content Include="mappings\**\*.json">

You had some unit test project to test maps schema in this project?


Refers to: src/Microsoft.UpgradeAssistant.Mappings/Microsoft.UpgradeAssistant.Mappings.csproj:21 in 6f6cbb7. [](commit_id = 6f6cbb7, deletion_comment = False)

@jstedfast
Copy link
Member Author

<Content Include="mappings\**\*.json">

You had some unit test project to test maps schema in this project?

Yes, see the tests/ directory. The tests parse the JSON files and verify that they are syntactically correct values (as well as JSON, obviously).

@jstedfast jstedfast force-pushed the dev/jestedfa/mappings branch 2 times, most recently from caf4a33 to c053366 Compare May 16, 2024 18:14
abpiskunov
abpiskunov previously approved these changes May 16, 2024
Copy link
Contributor

@abpiskunov abpiskunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jstedfast jstedfast requested a review from abpiskunov May 28, 2024 19:54
@mgoertz-msft mgoertz-msft enabled auto-merge (squash) May 28, 2024 20:53
@mgoertz-msft
Copy link
Contributor

@abpiskunov I suspect that the dotnet.upgrade-assistant check does not complete because UA is no longer in this repo. Do you know where this check is marked as required and how to remove it?

@mgoertz-msft mgoertz-msft merged commit 032a4c7 into main May 28, 2024
1 check passed
@jstedfast jstedfast deleted the dev/jestedfa/mappings branch May 29, 2024 15:02
@gewarren
Copy link

@jstedfast Is the binary analysis feature still supported? We were linking to the documentation for it from learn.microsoft.com, but now the link is broken and I'm not sure what to link to.

@abpiskunov
Copy link
Contributor

binary analysis is supported however the CLI experience is different and our PMs are working on the blog post about that and learning docs. IN mean while new UA cli should guide you how to use new binary analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants