App target frameworks fix #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisualStudioFinder.GetLatestPath() uses COM to iterate over the install locations for Visual Studio but somehow, once the method returns to the caller (GetLatestVisualStudioPath), none of the methods can be relied on to return sane values. Therefore, the easiest solution is to track the values we care about and just return them to our caller who can then avoid needing to re-make the same COM invocations a second time.
src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/VisualStudioFinder.cs
Outdated
Show resolved
Hide resolved
added 3 commits
March 14, 2023 08:14
DianaSoltani
changed the title
jstedfast
previously approved these changes
Mar 16, 2023
.../maui/Microsoft.DotNet.UpgradeAssistant.Extensions.Maui/MauiTargetFrameworkSelectorFilter.cs
Show resolved
Hide resolved
added 2 commits
March 16, 2023 13:12
…ty Toolkit to latest
…s://github.com/dotnet/upgrade-assistant into dev/dianasoltani/MobileAppTargetFrameworks-fix
...ns/maui/Microsoft.DotNet.UpgradeAssistant.Extensions.Maui/PackageMaps/XamarinPackageMap.json
Outdated
Show resolved
Hide resolved
mgoertz-msft
approved these changes
Mar 16, 2023
abpiskunov
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some MSBuild and NuGet TFM bugs. We want to properly refer to .android.csproj and .ios.csproj with the appropriate target framework formatting.
The mono and ios frameworks have been updated to net7.
This improves on Nuget package compatibility checks for the Android and iOS platforms.
Also updated the package mapper to address #1434