macOS port of the upgrade-assistant #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jstedfast
force-pushed
the
dev/jestedfa/macos-port
branch
4 times, most recently
from
ed2787f to
a8a100a
Compare
jstedfast
force-pushed
the
dev/jestedfa/macos-port
branch
2 times, most recently
from
3e9ad38 to
0a8edf3
Compare
jstedfast
force-pushed
the
dev/jestedfa/macos-port
branch
from
3443056 to
0f15bc5
Compare
jstedfast
force-pushed
the
dev/jestedfa/macos-port
branch
from
787c53e to
56e01b5
Compare
src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/MSBuildWorkspaceUpgradeContext.cs
Outdated
Show resolved
Hide resolved
src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/UpgraderMsBuildExtensions.cs
Outdated
Show resolved
Hide resolved
src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/VisualStudioFinder.cs
Show resolved
Hide resolved
src/extensions/default/Microsoft.DotNet.UpgradeAssistant.Steps.Packages/PackageUpdaterStep.cs
Show resolved
Hide resolved
src/extensions/try-convert/MSBuild.Abstractions/PathComparer.cs
Outdated
Show resolved
Hide resolved
src/extensions/try-convert/MSBuild.Abstractions/ProjectItemComparer.cs
Outdated
Show resolved
Hide resolved
...tensions/try-convert/MSBuild.Conversion.Project/ProjectRootElementExtensionsForConversion.cs
Show resolved
Hide resolved
src/extensions/wcf/Microsoft.DotNet.UpgradeAssistant.Extensions.WCFUpdater/WCFUpdateStep.cs
Show resolved
Hide resolved
...alyzers/Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers.Test/AnalyzerTests.cs
Show resolved
Hide resolved
...sions/wcf/Microsoft.DotNet.UpgradeAssistant.Extensions.WCFUpdater.Test/UpdaterFactoryTest.cs
Show resolved
Hide resolved
...nsions/wcf/Microsoft.DotNet.UpgradeAssistant.Extensions.WCFUpdater.Test/WCFUpdateStepTest.cs
Show resolved
Hide resolved
tests/extensions/web/Microsoft.DotNet.UpgradeAssistant.Steps.Razor.Tests/MappedSubTextTests.cs
Show resolved
Hide resolved
Needed to canonicalize the EvaluatedInclude paths before comparing them.
The upgrade-assistant uses dotnet's MSBuild while older Xamarin.iOS/Mac/Android/etc
projects used Mono's XBuild (an MSBuild clone).
Unfortunately, there's no way to specify that dotnet's MSBuild should look in both
/usr/local/share/dotnet/sdk/{version} directory *and* in the
/Library/Frameworks/Mono.framework/External/xbuild directories for the
$(MSBuildExtensionsPath) imports.
In order to be able to load Xamarin.* projects, we need to create a temp dir that
includes *both* the standard targets/props files *and* the Xamarin props/targets files
and the only way to do that seems to be to create a temp directory full of symlinks.
Instead of using projectPath.Split('/').Last() and then result.Substring(),
just get the start/end indexes of the substring we want and only do 1
Substring() operation.
…g whether or not to use sudo dotnet commands
These probably don't make sense to try to migrate on macOS.
…symlinks Surface these exceptions to the user.
Use a different approach to avoid exceptions trying to create a symlink that already exists.
jstedfast
force-pushed
the
dev/jestedfa/macos-port
branch
from
64b528d to
3f30d7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PRs which target a specific extension within UA, changes won't be approved by a member of the
dotnet-upgrade-assistant-admingroup until a member of the code owners of the extension has approved, when required.Description
This set of code-changes gets the upgrade-assistant tool working on macOS, with the main goal of supporting Xamarin.Forms -> MAUI migration.
Addresses #550
Addresses #1076