Fixes for MAUI, logging, failed step repetitions, etc. #1403
Conversation
* Avoid unnecessary TFM merges for MAUI TFM SelectorFilter * Always show 'dotnet --info' in case of workload install failure * Added more information to log messages, such as project names * Added MAUI step results to SARIF output * Prevent endless failed step repetitions by adding Failded to IsDone * Added failure level info to SARIF output using Note as default * Added additional optional failure details to SARIF output * Removed about:blank default which caused empty browser windows on click * Fixed a few grammar and spelling issues
|
Looking at test failures... |
|
@twsouthwick Looks like you may have authored the In my experience a failed step gets repeated endlessly in non-interactive mode, so I needed to change this behavior to fix that. Unless the step status gets reset, due to a |
|
We discussed the failed step behavior this morning and it looks like this can be useful for interactive scenarios, so we decided to keep it as is for interactive and change it for non-interactive scenarios. I will see how/where we can best make that distinction and update the PR. |
* Don't return failed steps in non-interactive mode instead * Updated tests to reflect new SARIF output * Re-enabled Maui E2E tests * Introduced TestOptions to skip the `MauiWorkloadUpgradeStep` during E2E tests
… SARIF output * Temporarily re-enable the Maui workload install step to diagnose Maui E2E failures
…led (and the install step fails on the machine) * Skip the Apply part of the `MauiWorkloadUpgradeStep` but keep the rest for diagnostic output in the test
|
@dotnet/dotnet-upgrade-assistant-admin and @dotnet/dotnet-upgrade-assistant-uwp Please review your areas of this PR. Thank you! |
For PRs which target a specific extension within UA, changes won't be approved by a member of the
dotnet-upgrade-assistant-admingroup until a member of the code owners of the extension has approved, when required.Description
Addresses #1359
Addresses #988