Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Update SDK #663

Closed
wants to merge 1 commit into from
Closed

Update SDK #663

wants to merge 1 commit into from

Conversation

JunTaoLuo
Copy link

Fixes #660 cc @tebeco

@tebeco
Copy link
Contributor

tebeco commented Sep 16, 2020

will take a shoot at the branch in ~30-60min

@tebeco
Copy link
Contributor

tebeco commented Sep 16, 2020

from the issue:

IIRC I might have seen a reference to System.Reactive (dotnet/réactive)
(i did not fully check that this affirmation is actually true)

given the changes in recent prview about breaking changes regarding WinRT
Also Rx have dependencies towards WinRt (scheduler maybe ?)

You might want to recheck that the code of this repo using Rx still runs on RC1

especially after this comment from yesterday:

dotnet/reactive#1237 (comment)

@tebeco
Copy link
Contributor

tebeco commented Sep 16, 2020

I do confirm that fixes the bug from VS here too

did not checked the Rx part in Hosting

@tebeco
Copy link
Contributor

tebeco commented Sep 17, 2020

E2E seems also affected by project.assets.json somehow :D
image

the generated csproj is

<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <RootNamespace>Frontend</RootNamespace>
  </PropertyGroup>

  <ItemGroup>
    <ProjectReference Include="$(TyeLibrariesPath)\Microsoft.Tye.Extensions.Configuration\Microsoft.Tye.Extensions.Configuration.csproj" />
  </ItemGroup>

</Project>

Copy pasting all the test project aside, works once i move this project somwhere else on disk and run dotnet build manually with a global.json pointing to RC1

more info :
image

@tebeco
Copy link
Contributor

tebeco commented Sep 28, 2020

@JunTaoLuo
I'm observing a strange behavior in dotnet restore and dotnet build on the generated proj file
I'm not really sure but it look like there's no "SDK" imported so when Build target is ran, it does not know about restore
Also running only restore does nothing

The result is that project.assets.json are missing

image

@tebeco
Copy link
Contributor

tebeco commented Sep 28, 2020

thx @JunTaoLuo for #674, rebasing this one seems ok now
This fixes the previous failure during E2E, especially the dotnet restore that now ... restore :D

I can't explain how most of the test used docker but not these :D
image

@JunTaoLuo
Copy link
Author

Huh yea maybe those tests need to have updated conditions. I have Docker installed an running on my machines so I never noticed. FYI, I'm going to close this PR in favour of #668. That PR is our automation catching up with the SDK versions.

@JunTaoLuo JunTaoLuo closed this Sep 28, 2020
@tebeco
Copy link
Contributor

tebeco commented Sep 28, 2020

docker detection seems flacky, I even added a throw in that ConditionalFact ... never throw even on rebuild, or clear all
had to re-run ./restore I think eventually all ran
I think the same happened month ago in dotnet/aspnetcore regarding SignalR and redis tests

@JunTaoLuo JunTaoLuo deleted the johluo/sdk branch January 6, 2021 23:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants