This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Removes Dapr placement server management #1191
Merged
+57
−75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets Tye out of the business of creating Dapr placement services, as most applications can use the one provided by the standard Dapr initialization (e.g. via
dapr init
) and that's whatdapr
assumes when running sidecars unless otherwise directed. (If no placement service was running, just spinning one up as Tye was previously doing isn't sufficient due to dependencies on a properly configured state store.) Maintains the ability to have Dapr sidecars use a different port viaplacement-port
. The Dapr extension will check whether Dapr has been initialized (e.g. viadapr --version
) and fails if not, as a further hint to the user that something is amiss.Resolves #1175
Resolves #1177