-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove formatPath() that adds ".\" or "./" to the executable. #81
Conversation
@@ -71,11 +71,6 @@ object DotnetRunner extends Logging { | |||
// Reuse windows-specific formatting in PythonRunner. | |||
dotnetExecutable = PythonRunner.formatPath(resolveDotnetExecutable(driverDir, args(1))) | |||
otherArgs = args.slice(2, args.length) | |||
} else if (new File(args(0)).isDirectory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this since there is no use case for this.
@@ -200,17 +195,6 @@ object DotnetRunner extends Logging { | |||
resolvedExecutable | |||
} | |||
|
|||
// When executing in YARN cluster mode, the name of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that for YARN cluster mode, the user has to ship the executable with dependencies via Zip file and the full path for the executable is constructed from it. Thus, this function is not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
formatPath()
adds "." or "." to the .NET executable. This forces the user to specify a full path for the .NET executable passed tospark-submit
. For example,is not allowed, since
formatPath()
changesdotnet
to.\dotnet.exe
even if dotnet is in the PATH.