Remove formatPath() that adds ".\" or "./" to the executable. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
commented
May 1, 2019
| @@ -71,11 +71,6 @@ object DotnetRunner extends Logging { | |||
| // Reuse windows-specific formatting in PythonRunner. | |||
| dotnetExecutable = PythonRunner.formatPath(resolveDotnetExecutable(driverDir, args(1))) | |||
| otherArgs = args.slice(2, args.length) | |||
| } else if (new File(args(0)).isDirectory) { | |||
There was a problem hiding this comment.
Removing this since there is no use case for this.
imback82
commented
May 1, 2019
| @@ -200,17 +195,6 @@ object DotnetRunner extends Logging { | |||
| resolvedExecutable | |||
| } | |||
|
|
|||
| // When executing in YARN cluster mode, the name of the | |||
There was a problem hiding this comment.
Note that for YARN cluster mode, the user has to ship the executable with dependencies via Zip file and the full path for the executable is constructed from it. Thus, this function is not needed.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formatPath()adds "." or "." to the .NET executable. This forces the user to specify a full path for the .NET executable passed tospark-submit. For example,is not allowed, since
formatPath()changesdotnetto.\dotnet.exeeven if dotnet is in the PATH.