Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax spark version check #74

Merged
merged 5 commits into from
Apr 30, 2019
Merged

Relax spark version check #74

merged 5 commits into from
Apr 30, 2019

Conversation

suhsteve
Copy link
Member

No description provided.

@suhsteve
initial commit

Verified

This commit was signed with the committer’s verified signature. The key has expired.
2opremio Alfonso Acosta
GPG key ID: A7A46951D61AF0FA
Expired
Verified
Learn about vigilant mode
1dafc1e
@suhsteve
Copy link
Member Author

Used the wrong shortcut to format code.

@suhsteve
use scalafmt to format code instead of default formatter

Verified

This commit was signed with the committer’s verified signature. The key has expired.
2opremio Alfonso Acosta
GPG key ID: A7A46951D61AF0FA
Expired
Verified
Learn about vigilant mode
2318bab
@rapoth
Copy link
Contributor

rapoth commented Apr 30, 2019

CC: @amgadmadkour #49 (comment)

@rapoth rapoth requested a review from imback82 April 30, 2019 19:58
suhsteve and others added 3 commits April 30, 2019 14:02
@suhsteve
Update log line

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
1552894
@suhsteve
fix Option handling

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
97c33db
@imback82
Merge branch 'master' into spark_relax_version
a41c24c
imback82
imback82 approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imback82 imback82 merged commit 3308940 into dotnet:master Apr 30, 2019
@suhsteve suhsteve deleted the spark_relax_version branch May 1, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imback82 imback82

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suhsteve @rapoth @imback82