Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFrameWriter PartitionBy fails #56

Merged
merged 1 commit into from
Apr 26, 2019
Merged

DataFrameWriter PartitionBy fails #56

merged 1 commit into from
Apr 26, 2019

Conversation

imback82
Copy link
Contributor

Addresses #55

Will be adding E2E tests.

@imback82 imback82 mentioned this pull request Apr 25, 2019
Closed
@imback82 imback82 changed the title [WIP] DataFrameWriter PartitionBy fails DataFrameWriter PartitionBy fails Apr 26, 2019
@rapoth rapoth self-requested a review April 26, 2019 01:04
@imback82 imback82 self-assigned this Apr 26, 2019
rapoth
rapoth approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@rapoth rapoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imback82 imback82 merged commit 8f33a16 into dotnet:master Apr 26, 2019
@imback82 imback82 deleted the dataframe_bug branch April 26, 2019 01:07
@imback82
Copy link
Contributor Author

Unit tests will be addressed in #59

@imback82 imback82 mentioned this pull request Apr 26, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapoth rapoth rapoth approved these changes

Assignees

@imback82 imback82

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imback82 @rapoth