-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TimestampType #428
Conversation
@elvaliuliuliu Is this ready for review? |
Yes, this is ready for review! Looks like request reviewers function is removed from github, so in the future, I will ping here when a WIP PR is ready for review. Thanks! |
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfSimpleTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfSimpleTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfSimpleTypesTests.cs
Outdated
Show resolved
Hide resolved
…/spark into elva/timestampType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor comments, but generally looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit comment
…/spark into elva/timestampType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @elvaliuliuliu
This PR exposes
Timestamp
class and supportsTimestampType
as below:DataFrame.Collect()
forTimestampType
.CreateDataFrame
that takes inTimestamp
.Timestamp
and UDF that returnsTimestamp
.