Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TimestampType #428

Merged
merged 34 commits into from
Mar 31, 2020
Merged

Conversation

elvaliuliuliu
Copy link
Contributor

@elvaliuliuliu elvaliuliuliu commented Feb 22, 2020

This PR exposes Timestamp class and supports TimestampType as below:

  1. Support DataFrame.Collect() for TimestampType.
  2. Support CreateDataFrame that takes in Timestamp.
  3. Support UDF that takes in Timestamp and UDF that returns Timestamp.

@imback82 imback82 added the enhancement New feature or request label Feb 24, 2020
@elvaliuliuliu elvaliuliuliu changed the title [WIP] Support TimestampType Support TimestampType Mar 10, 2020
@imback82
Copy link
Contributor

@elvaliuliuliu Is this ready for review?

@elvaliuliuliu
Copy link
Contributor Author

elvaliuliuliu commented Mar 10, 2020

@elvaliuliuliu Is this ready for review?

Yes, this is ready for review!

Looks like request reviewers function is removed from github, so in the future, I will ping here when a WIP PR is ready for review. Thanks!

src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/SimpleTypes.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/Timestamp.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/Timestamp.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/Timestamp.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/Timestamp.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/Timestamp.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor comments, but generally looks good to me.

src/csharp/Microsoft.Spark.UnitTest/Sql/TimestampTests.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark.UnitTest/Sql/TimestampTests.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/SimpleTypes.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/Timestamp.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/Timestamp.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/Types/Timestamp.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit comment

src/csharp/Microsoft.Spark.UnitTest/Sql/TimestampTests.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @elvaliuliuliu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants