Follow up on UDF that takes in and returns Row #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhsteve
reviewed
Jan 29, 2020
imback82
reviewed
Jan 29, 2020
| Assert.Equal(expected, actual); | ||
| } | ||
|
|
||
| // Row is a part of top-level column. |
There was a problem hiding this comment.
This comment is a bit misleading. We can say UDF that takes multiple Rows, etc.
There was a problem hiding this comment.
Sure, I have updated to Multiple Rows.
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
suhsteve
reviewed
Jan 29, 2020
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
imback82
reviewed
Jan 29, 2020
| @@ -65,15 +65,6 @@ public object construct(object[] args) | |||
| s_schemaCache = new Dictionary<string, StructType>(); | |||
| } | |||
|
|
|||
| // When a row is ready to be materialized, then construct() is called | |||
There was a problem hiding this comment.
This is actually a breaking change, but @suhsteve is updating the worker version in his PR: https://github.com/dotnet/spark/pull/387/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #376 and #214 to remove the materialization inside
construct(). And change it on the worker side. This would make the behavior consistent for UDF that takes in Row and that returns Row.