Support More Aggregate Methods #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhsteve
reviewed
Sep 25, 2019
suhsteve
reviewed
Sep 25, 2019
src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/DataFrameTests.cs
Outdated
Show resolved
Hide resolved
suhsteve
reviewed
Sep 25, 2019
imback82
previously approved these changes
Sep 25, 2019
src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/DataFrameTests.cs
Outdated
Show resolved
Hide resolved
suhsteve
reviewed
Sep 25, 2019
| @@ -404,6 +404,22 @@ public void TestSignaturesV2_3_X() | |||
| Assert.IsType<RelationalGroupedDataset>(_df.GroupBy(_df["age"])); | |||
| Assert.IsType<RelationalGroupedDataset>(_df.GroupBy(_df["age"], _df["name"])); | |||
|
|
|||
| Assert.IsType<DataFrame>(_df.GroupBy("name").Mean("age")); | |||
| Assert.IsType<DataFrame>( | |||
| _df.WithColumn("tempAge", _df["age"]).GroupBy("name").Mean("age", "tempAge")); | |||
There was a problem hiding this comment.
for these GroupBy.fn tests, let's pull out _df.WithColumn("tempAge", _df["age"]).GroupBy("name") into a var within it's own scope, { ... } and reuse.
There was a problem hiding this comment.
Same with _df.GroupBy("name") as well.
There was a problem hiding this comment.
I have made the changes. Please let me know if the var name makes sense. Thanks!
elvaliuliuliu
dismissed stale reviews from imback82 and suhsteve
via
520ba68
suhsteve
reviewed
Sep 25, 2019
| Assert.IsType<DataFrame>(_df.GroupBy("name").Sum("age")); | ||
| Assert.IsType<DataFrame>( | ||
| _df.WithColumn("tempAge", _df["age"]).GroupBy("name").Sum("age", "tempAge")); | ||
| var relationalGroupedDataset = _df.GroupBy("name"); |
There was a problem hiding this comment.
Let's enclose this whole subsection with a { }. We can shorten the variable names. Just using df1 and df2 should suffice. Also use RelationalGroupedDataset instead of var
imback82
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes more aggregate methods for
RelationalGroupedDatasetlikeMean(),Max(),Avg(),Min(). Follow up on issue #260