Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SparkSession.Range - Issue:224 #225

Merged
merged 20 commits into from
Aug 31, 2019
Merged

Implement SparkSession.Range - Issue:224 #225

merged 20 commits into from
Aug 31, 2019

Conversation

GoEddie
Copy link
Contributor

@GoEddie GoEddie commented Aug 28, 2019

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged. - references issue [FEATURE REQUEST]: Support for SparkSession.Range() #224
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Description:

Implement Range on SparkSession, the Scala version returns a typed DataSet but as I don't think we can do that in dotnet I followed the pyspark implementation which returns a DataFrame.

If this should return a DataFrameReader instead let me know.

@GoEddie GoEddie changed the title WIP: Implement SparkSession.Range - Issue:224 Implement SparkSession.Range - Issue:224 Aug 29, 2019
@rapoth rapoth requested review from suhsteve and imback82 August 29, 2019 17:38
@imback82
Copy link
Contributor

Fixes #224

@imback82 imback82 added the enhancement New feature or request label Aug 30, 2019
@GoEddie
Copy link
Contributor Author

GoEddie commented Aug 30, 2019

I think that is all the comments covered, any more please let me know!

src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/Sql/SparkSession.cs Outdated Show resolved Hide resolved
GoEddie and others added 4 commits August 30, 2019 23:05
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
GoEddie and others added 4 commits August 30, 2019 23:06
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imback82 imback82 merged commit 4e66536 into dotnet:master Aug 31, 2019
@GoEddie GoEddie deleted the feature/range branch September 1, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants