-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SparkSession.Range - Issue:224 #225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoEddie
changed the title
WIP: Implement SparkSession.Range - Issue:224
Implement SparkSession.Range - Issue:224
Aug 29, 2019
AFFogarty
reviewed
Aug 29, 2019
src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/FunctionsTests.cs
Outdated
Show resolved
Hide resolved
suhsteve
reviewed
Aug 29, 2019
src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/FunctionsTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/FunctionsTests.cs
Outdated
Show resolved
Hide resolved
suhsteve
reviewed
Aug 29, 2019
src/csharp/Microsoft.Spark.E2ETest/IpcTests/Sql/FunctionsTests.cs
Outdated
Show resolved
Hide resolved
suhsteve
reviewed
Aug 29, 2019
suhsteve
reviewed
Aug 29, 2019
Fixes #224 |
suhsteve
reviewed
Aug 30, 2019
imback82
reviewed
Aug 30, 2019
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
I think that is all the comments covered, any more please let me know! |
suhsteve
reviewed
Aug 30, 2019
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
Co-Authored-By: Steve Suh <suhsteve@gmail.com>
suhsteve
approved these changes
Aug 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
imback82
approved these changes
Aug 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged. - references issue [FEATURE REQUEST]: Support for SparkSession.Range() #224Description:
Implement Range on SparkSession, the Scala version returns a typed DataSet but as I don't think we can do that in dotnet I followed the pyspark implementation which returns a DataFrame.
If this should return a DataFrameReader instead let me know.