Support for SparkSession.conf #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
reviewed
Jul 24, 2019
| /// </summary> | ||
| /// <param name="key">Key to use</param> | ||
| /// <param name="defaultValue">Default value to use</param> | ||
| public string Get(string key, string defaultValue) => |
There was a problem hiding this comment.
Let's also expose public string Get(string key).
There was a problem hiding this comment.
I was considering this, but spark will throw a java.util.NoSuchElementException if the key does not exist. This exact exception doesn't seem like it'll be propagated back through the _jvmObject.Invoke call. I assume this was also why SparkConf.cs didn't implement this method.
There was a problem hiding this comment.
We have many APIs where exceptions are thrown on the JVM side. I also, check the PySpark and they expose this function as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow retrieving and modifying a SparkSessions configuration without requiring a
stopand recreation of the SparkSession.