Automate C# formatting using dotnet-format

[imback82]

Explore adopting https://github.com/dotnet/format to automate the process of formatting source code similar to scalafmt (#153).

[nmnick18]

I'd like to take up this issue

[imback82]

Cool, that will be great. Please let me know if we can retain most of the existing formatting or not. Thanks!

[nmnick18]

I am gonna need more context, but is this mainly looking to use some of the 'format' code to automatically format the scala code?

Bare with me here lol, this is my first open source contribution (yay!)

[postmeback]

Any update on this ?

[ghostp13409]

Hey, is this issue still available to work on? I would like to give it a try.

[wudanzy]

Seem like no progress within 3 years, please feel free to have a try!

[ghostp13409]

Thanks. I'll get started with installing dotnet/Format into the project. However, I do have a few doubts.

1. the issue given for reference leads to some feature request Support Trigger in DataStreamWriter. I don't understand how am i supposed to see scalafmt things in there.
2. I found a C# Coding Style guideline. Do you want me to implement those rules in .editorconfig file? because those things already seems to be in place.
3. Just to be sure, you want me to only work on src/csharp/ and not anything else, correct?
4. I couldn't find any guideline for how should i make the contribution. should I just work on the main, create a new branch or create my own fork for the issue?

[wudanzy]

For 1, I don't have much context there, I would guess that code was formatted using that formatter.
For 2, I think you understanding is right. We can use some rule so that any future code can have the same style, but you may need some exploration, I am new to C#. Please check how that's done in other C# repos and check if this item was obsoleted. It is a request 6 years ago.
For 3, C# changes are only in that directory. You can contribute to other directories if you have other ideas.
For 4, usually you need to fork on to your own repo and using a dev branch, after you are done,you create a PR to request merging to the main branch of dotnet spark.