Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove portable prebuilts: disable building Crossgen2 pack #1945

Merged
merged 3 commits into from
Dec 8, 2020

Conversation

dagood
Copy link
Member

@dagood dagood commented Dec 8, 2020

For #1937.

Building the Crossgen2 pack from source has a few issues:

Self-contained packages like this one bring down lots of prebuilts. We can disable
self-contained, but this only fixes this some prebuilts, not all. See
#1937. Also, disabling self-contained makes the
source-built Crossgen2 pack different from the Microsoft build's and potentially not work in the
expected scenarios.

Even if we managed to build it without prebuilts, there is no mechanism to distribute the
Crossgen2 pack in distro packages. This is the same problem as runtime packs. See
#1568

Running local build.

@dagood dagood self-assigned this Dec 8, 2020
@dagood dagood merged commit 5f97755 into dotnet:master Dec 8, 2020
@dagood dagood deleted the portable-prebuilts branch December 8, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants