Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Add macOS brew image/env workaround #1817

Closed
wants to merge 1 commit into from
Closed

[master] Add macOS brew image/env workaround #1817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .vsts.pipelines/steps/setup-macos-native.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ steps:
)
}
set -ex
# Work around image/environment bug: https://github.com/actions/virtual-environments/issues/1811
brew uninstall openssl@1.0.2t
brew uninstall python@2.7.17
brew untap local/openssl
Comment on lines +12 to +14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I guess this is to be expected:

  [21:17:11.11] Building 'runtime'
...
    Commencing CoreCLR Repo build
    __DistroRid: osx-x64
    __RuntimeId: osx-x64
    Setting up directories for build
    Checking prerequisites...
    /usr/local/bin/pkg-config
    Please install openssl before running this script, see https://github.com/dotnet/runtime/blob/master/docs/workflow/requirements/macos-requirements.md
  /Users/runner/work/1/s/artifacts/src/runtime.bf456654f9a4f9a86c15d9d50095ff29cde5f0a4/src/coreclr/runtime.proj(33,5):
    error MSB3073: The command ""/Users/runner/work/1/s/artifacts/src/runtime.bf456654f9a4f9a86c15d9d50095ff29cde5f0a4/src/coreclr/build-runtime.sh" -x64 -release -ci -keepnativesymbols -os OSX /p:OfficialBuildId=20200807.11 -nopgooptimize" exited with code 1.

Once it's practical to work on this (vs. AzDO general failures) we've got to figure out where we actually want to get openssl from. Maybe after the brew update we can install it again? I haven't looked very far into why exactly we need to uninstall it in the first place. (My impression is that the macOS image comes with a busted brew installation that we have to un-break before we can run brew update, but this might not be accurate.)

brew untap local/python2
# Work around brew bug: https://github.com/dotnet/coreclr/pull/21913
brew update
# Install macOS native dependencies not present in hosted pool.
Expand Down